From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B635F371D13 for ; Sun, 12 Jul 2026 07:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783841576; cv=none; b=WuYDOPplse76Ej57nZVtF2I0192hrHNYliyH7POo28UzIBwWWORD6jN01eYr/M+/AXHATFbxKMgHbdQIa4x9fd8q824xDHwVFzRsLS3N8T3CTJPPP4FQo7B+BQnDPzdA3QOHRzoeCHhu7UabZi0PTl0LARRzdySPSfkWVR3SAtI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783841576; c=relaxed/simple; bh=aZqbzkbyclHQJSmWx0H+gTBJ4s5rShDCPWr/sm11Giw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Zezix9FjXqWByCY1yNb/iSZKFM9H3VzR5f2aA7Fq/BVxJSHxmDPFZglLMmASh+sctlEfbgPWSmZr2wfU0mwDQrpLdeJNr/IaE6k2pRQt1ksIoe6kVhiZ38kKlmQW5lnj+7Z5HvBPmX//qLoxZaxPuIVZagrgJTQhibiUqxeMqhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mVr6wu0z; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mVr6wu0z" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-84862b0d5f8so1608692b3a.3 for ; Sun, 12 Jul 2026 00:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783841575; x=1784446375; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=fYobm8dTP6JvcBfLyO1CnudZo9D607kvLt1hZ/YvyDM=; b=mVr6wu0zY97iLRLK8SqbjDtReHxHFOI0oj7bULNIkTdRnN4S2oHjSQyEI8WvpTUSBm b61oNKHJFwqvaj+G5QcKPQ/LUEyJoOUnMUtohAEEfKn8zG2b+ORQtAha6MtjSe+p4paj dqslfSUNtStfJQDbhNb/2q3qWKeGVnWColXhjHVaYvcEYQqGcsDGQPlyJeh1TQjWNx7a supS9sM72NhXY/I2fQEhn/h6/Ll33RkCXYfEx5A1H5vA8ulQcUwmpye2LrrdbtC6Hrq0 xB9BhRsoPGLocy+z4OFYAdxy+gGnrYQuBV8/7gdtl8jrmQn8gUKOAw6lRtiCrfYmGFW6 066A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783841575; x=1784446375; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fYobm8dTP6JvcBfLyO1CnudZo9D607kvLt1hZ/YvyDM=; b=YnQLbev3l7BhJFdWI5SxcjwnRoTCIKlFLqjyyv1UWKxP1jVHLwgFef1JkGDbnBH7Ql c5Q4+eBlIvmg/JkC7Bkc/m9yxIY5zWe5+z3CJRvk6T7U7hJieE3FJix8R9H67pfU29xm Pk+hec0Ro2FXGyQSibooxfMdvdjBcSYRIhGYPbSWA4xk+4o9u9BQhTSffGFsXVn18bnq Dl/3eaB6LOqxVspj2E06IUTwHIGXIoppvPHSwMZhC0hfjpNROdsyicvKvPi0ptxTWr5o puppnUmX8jKdM9pDbfs4j3HYyIJlW4fwo0uaP/3UuYdCH1crNG9kpdHeRDFC1ByVOoCZ oB+g== X-Forwarded-Encrypted: i=1; AHgh+RqDx3/p0oYhwn6zYAe7evesS3b5EfO3rA0JU1Uk5UA146n9/RbtKMULR0FzUY+UJ1VpuoY//n5I1m9edb4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn6zC1tAkyG4UnqJugrAMHStMxxc7AjZusclISBv4vl1bLTNx5 uTR66TmVI1ea21k6Sf1btVvi6C2z7xrUEOTZtpfvt88v4ZGBSgsQNGhU X-Gm-Gg: AfdE7cnQ3RV6GRr86U+grzTaY9aGRanDjnMRGtrtlUgticIEfj3LVKxrLnejUBISzcd uJBk63FNFjSTP1ZbrV2At7McEULHsMtf6VcD3FPI+y1pY3kWTtwp111Yi5IhvxPZJxB5GLAjMMX 4F9eVkGIvHJbupzyvP8lYzhBaEHGbFR2SOD7JIJMH0372D2fdpF2Qz3bBZgxxGZSiZeylL57BGC 7w5zdy2RsMdsrc/5b6eTFtus6qWoxXtK4pQBKWI1XAM0Ae38AhpdW3sn3p+z8NlBqsll9AlrEOd qpdDL7QNXx3dg207oWoh56V80rq3GF/Lq64HmwdNZnKMdi0fT+2shq6p3RZ8Rks+RRz2rHrL+0U ToX2/jwOAJyoPquCMhHQprTyL+UVISyRF7SmL4k2qrn2KhlL/SZf5TXE/crfvyKJc X-Received: by 2002:a05:6a00:14ce:b0:847:7f7a:dd18 with SMTP id d2e1a72fcca58-848895db925mr4637512b3a.3.1783841574926; Sun, 12 Jul 2026 00:32:54 -0700 (PDT) Received: from localhost ([2001:da8:7001:11::cb]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6b975a0sm12376839b3a.14.2026.07.12.00.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 00:32:54 -0700 (PDT) Date: Sun, 12 Jul 2026 15:32:11 +0800 From: Inochi Amaoto To: Alex Elder , Inochi Amaoto , Jingoo Han , Manivannan Sadhasivam , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Christian Bruel , Frank Li , Nam Cao , Qiang Yu , Krishna Chaitanya Chundru , Xincheng Zhang , Siddharth Vadapalli , Andy Shevchenko , Vidya Sagar , Neil Armstrong , Gustavo Pimentel Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, Yixun Lan , Longbin Li Subject: Re: [PATCH v4 3/6] PCI: spacemit-k1: Add device id update helper Message-ID: References: <20260709040027.958400-1-inochiama@gmail.com> <20260709040027.958400-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jul 10, 2026 at 11:01:27AM -0500, Alex Elder wrote: > On 7/8/26 11:00 PM, Inochi Amaoto wrote: > > Both K1 and K3 needs to set vendor id and device id, add a helper function > > s/needs/need/ > > > to simplify this. > > I think someone might have commented on this, but I expected to find > that the next patch would fill in the code that's needed to support > K3, but that patch is at the end of your series. > > The reason I say it here is that I wondered while looking at this > one why it was needed to create this helper function. I now know > that k3_pcie_init() will call it (but I had to find that in the > last patch, which was later than I expected). > > Your series should start with DT binding changes, then code changes, > and (often) end with DTS changes. > There is another order, starts with the common change, then the specific logic for a specific driver. This is the order of this patchset. For this patchset, starting with DT binding changes makes the common part hard to be identified and taken. > Anyway, this looks good. > > Reviewed-by: Alex Elder > > > Signed-off-by: Inochi Amaoto > > --- > > drivers/pci/controller/dwc/pcie-spacemit-k1.c | 17 +++++++++++++---- > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-spacemit-k1.c b/drivers/pci/controller/dwc/pcie-spacemit-k1.c > > index e22ecbd09579..31aac056b68e 100644 > > --- a/drivers/pci/controller/dwc/pcie-spacemit-k1.c > > +++ b/drivers/pci/controller/dwc/pcie-spacemit-k1.c > > @@ -56,6 +56,7 @@ struct k1_pcie_device_data { > > const struct dw_pcie_ops *ops; > > int (*parse_port)(struct k1_pcie *k1); > > unsigned int max_phy_count; > > + unsigned int device_id; > > }; > > struct k1_pcie { > > @@ -186,6 +187,16 @@ static void k1_pcie_disable_aspm_l1(struct k1_pcie *k1) > > dw_pcie_dbi_ro_wr_dis(pci); > > } > > +static void k1_pcie_set_device_id(struct k1_pcie *k1) > > +{ > > + struct dw_pcie *pci = &k1->pci; > > + > > + dw_pcie_dbi_ro_wr_en(pci); > > + dw_pcie_writew_dbi(pci, PCI_VENDOR_ID, PCI_VENDOR_ID_SPACEMIT); > > + dw_pcie_writew_dbi(pci, PCI_DEVICE_ID, k1->data->device_id); > > + dw_pcie_dbi_ro_wr_dis(pci); > > +} > > + > > static int k1_pcie_init(struct dw_pcie_rp *pp) > > { > > struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > > @@ -201,10 +212,7 @@ static int k1_pcie_init(struct dw_pcie_rp *pp) > > return ret; > > /* Set the PCI vendor and device ID */ > > - dw_pcie_dbi_ro_wr_en(pci); > > - dw_pcie_writew_dbi(pci, PCI_VENDOR_ID, PCI_VENDOR_ID_SPACEMIT); > > - dw_pcie_writew_dbi(pci, PCI_DEVICE_ID, PCI_DEVICE_ID_SPACEMIT_K1); > > - dw_pcie_dbi_ro_wr_dis(pci); > > + k1_pcie_set_device_id(k1); > > /* > > * Start by asserting fundamental reset (drive PERST# low). The > > @@ -406,6 +414,7 @@ static const struct k1_pcie_device_data k1_pcie_device_data = { > > .ops = &k1_pcie_ops, > > .parse_port = k1_pcie_parse_port, > > .max_phy_count = 1, > > + .device_id = PCI_DEVICE_ID_SPACEMIT_K1, > > }; > > static const struct of_device_id k1_pcie_of_match_table[] = { >