From: Herbert Xu <herbert@gondor.apana.org.au>
To: Yuho Choi <dbgh9129@gmail.com>
Cc: Olivia Mackall <olivia@selenic.com>,
Alexander Sverdlin <alex@sverdlin.org>,
Nishanth Menon <nm@ti.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] hwrng: ks-sa: Fix runtime PM cleanup on registration failure
Date: Mon, 13 Jul 2026 13:44:51 +1000 [thread overview]
Message-ID: <alRfM-Ygtmk1UNa2@gondor.apana.org.au> (raw)
In-Reply-To: <20260702233921.100478-1-dbgh9129@gmail.com>
On Thu, Jul 02, 2026 at 07:39:21PM -0400, Yuho Choi wrote:
> ks_sa_rng_probe() enables runtime PM and resumes the device before
> registering the hwrng. If devm_hwrng_register() fails, probe returns
> without dropping the runtime PM usage count or disabling runtime PM.
>
> Unwind the runtime PM state on the registration failure path, matching
> the cleanup done by remove().
>
> Fixes: e9009fb227fa ("hwrng: ks-sa - Use pm_runtime_resume_and_get() to replace open coding")
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
> ---
> drivers/char/hw_random/ks-sa-rng.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2026-07-13 3:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 23:39 Yuho Choi
2026-07-13 3:44 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alRfM-Ygtmk1UNa2@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alex@sverdlin.org \
--cc=dbgh9129@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=olivia@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox