From: Christoph Hellwig <hch@infradead.org>
To: Jeremy Bingham <jbingham@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
brauner@kernel.org, jkoolstra@xs4all.nl, jack@suse.cz,
djwong@kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v3 2/5] minix: add base iomap begin/end functions
Date: Mon, 13 Jul 2026 02:46:22 -0700 [thread overview]
Message-ID: <alSz7t4x0qjNO9ee@infradead.org> (raw)
In-Reply-To: <555d199291b37e5c1241df648b3adcd760c1fca6.1783707063.git.jbingham@gmail.com>
On Sat, Jul 11, 2026 at 01:59:06PM -0700, Jeremy Bingham wrote:
> Adds a new file, iomap.c, to fs/minix. This provides minix_iomap_begin,
> which is the iomap-based version of get_block in itree_common.c. It also
> provides minix_iomap_end, which is a no-op but required by the iomap_ops
> struct. This also undoes the nest of gotos inherited from get_block and
> uses a set of helper functions instead.
You don't need to describe what you do, you need to decribe why you
do it. Bonus points for explaining things like design tradeoffs.
next prev parent reply other threads:[~2026-07-13 9:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 20:59 [PATCH v3 0/5] minix: convert to iomap and add direct I/O Jeremy Bingham
2026-07-11 20:59 ` [PATCH v3 1/5] iomap: add iomap_symlink_write Jeremy Bingham
2026-07-13 9:44 ` Christoph Hellwig
2026-07-11 20:59 ` [PATCH v3 2/5] minix: add base iomap begin/end functions Jeremy Bingham
2026-07-13 9:46 ` Christoph Hellwig [this message]
2026-07-11 20:59 ` [PATCH v3 3/5] minix: update itree* files to add iomap functions Jeremy Bingham
2026-07-11 20:59 ` [PATCH v3 4/5] minix: add file operation functions Jeremy Bingham
2026-07-13 9:48 ` Christoph Hellwig
2026-07-13 19:17 ` Jeremy Bingham
2026-07-11 20:59 ` [PATCH v3 5/5] minix: iomap inode operations Jeremy Bingham
2026-07-13 9:32 ` [PATCH v3 0/5] minix: convert to iomap and add direct I/O Christoph Hellwig
2026-07-13 19:26 ` Jeremy Bingham
2026-07-14 0:53 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alSz7t4x0qjNO9ee@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=jbingham@gmail.com \
--cc=jkoolstra@xs4all.nl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®