From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nikhil Gautam <nikhilgtr@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Stefan Windfeldt-Prytz" <stefan.windfeldt-prytz@axis.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 4/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask
Date: Mon, 13 Jul 2026 14:25:31 +0300 [thread overview]
Message-ID: <alTLK220iMW25v6p@ashevche-desk.local> (raw)
In-Reply-To: <20260712202451.20822-5-nikhilgtr@gmail.com>
On Mon, Jul 13, 2026 at 01:54:51AM +0530, Nikhil Gautam wrote:
> GENMASK(h, l) requires h >= l, but OPT4001_CTRL_FAULT_COUNT is defined
> as GENMASK(0, 1). The define is currently unused so there is no
> functional impact, but fix it before anyone builds on it, and add the
> _MASK suffix for consistency with the neighbouring definitions.
...
> #define OPT4001_CTRL_OPER_MODE_MASK GENMASK(5, 4)
> #define OPT4001_CTRL_LATCH_MASK GENMASK(3, 3)
> #define OPT4001_CTRL_INT_POL_MASK GENMASK(2, 2)
> -#define OPT4001_CTRL_FAULT_COUNT GENMASK(0, 1)
> +#define OPT4001_CTRL_FAULT_COUNT_MASK GENMASK(1, 0)
The original indentation uses spaces only, please keep it the same style. Yeah,
it's supposed to use tabs, but here we are (it might be the material for another
change in the future).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-07-13 11:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 20:24 [PATCH 0/4] iio: light: opt4001: Fixes from code review Nikhil Gautam
2026-07-12 20:24 ` [PATCH v1 1/4] iio: light: opt4001: Fix read-modify-write of wrong register in power down Nikhil Gautam
2026-07-13 0:42 ` Jonathan Cameron
2026-07-13 3:33 ` Nikhil Gautam
2026-07-12 20:24 ` [PATCH v1 2/4] iio: light: opt4001: Fix incompatible pointer type passed to div_u64_rem() Nikhil Gautam
2026-07-13 0:43 ` Jonathan Cameron
2026-07-13 3:31 ` Nikhil Gautam
2026-07-12 20:24 ` [PATCH v1 3/4] iio: light: opt4001: Reject integration times with a non-zero seconds part Nikhil Gautam
2026-07-13 0:44 ` Jonathan Cameron
2026-07-12 20:24 ` [PATCH v1 4/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask Nikhil Gautam
2026-07-13 0:45 ` Jonathan Cameron
2026-07-13 11:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alTLK220iMW25v6p@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhilgtr@gmail.com \
--cc=nuno.sa@analog.com \
--cc=stefan.windfeldt-prytz@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®