From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E802272801 for ; Mon, 13 Jul 2026 16:19:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783959591; cv=none; b=MP3pM8rO+mLQVpgplRufQjSEKKzfw7L1xrL0fz0/XVPpb1WPKzCTPcCJOQMMjSSC8FU3zdBhfYvEPSJPnYbdA52kbDUeQjv6QkjIjp8SyTMQReqRIYVnd8lVIXWci9XHDdazTnbUHGkL+uHGGDCrd5TOserjfg3gXLQF0WEwcSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783959591; c=relaxed/simple; bh=8aKYsiqHb+e0EBWQSXGieX25f0W/ula19ldTW0J4XxM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c7ak4huH7Nyp3ELCFQzdZkLjcRxereLm9psnRqyAWt+6I+0fAslcn2ojdx8nqjy/NoAevA+02RoLw/5pcQXYPhrDn7xVoJwfC6SqoVdsOTR1gM8HinMLSPWT2tFNO+owI7cHKlstJH8n6cvhLzTbECXnFYiHXiYp8HEaqNJDE1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QycgO+id; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QycgO+id" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-493e8d4f4dcso26733605e9.0 for ; Mon, 13 Jul 2026 09:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783959587; x=1784564387; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=z6q8XmEubJ3GvXQaxRj4lMsNn/x2kGXa807Wdz3pI08=; b=QycgO+idv1TwB1WzxRkPikXDWlxUOiX+pOqino3h9N2fDfShWxg57tmjJoWCTB/qUB XLbZ7/PoTLQCAYU6c7iB4rDybH7FlLFt+BA9piuoQ28JB0bSZ3ay37M1ob+tBcGSIqh+ /tb/qEiZB1ZiLXATIakSUK1+d5uvFbO9LjY/j8gdW16JThFMXTXhXgPboYJn8aDwdSNG naNCJ3Ugx1UEkbfiHmD4PNT2tenAH+GLp72eK8VVep5tebiPB3nmUh0HKRaKvM6OW1Os NO7kcxUUBE1sxvjBngdk7hGEgCZwJjQjCzP5hgi5gTgIOEabdcWqp49xgDIDFSGhbzAD pFQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783959587; x=1784564387; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z6q8XmEubJ3GvXQaxRj4lMsNn/x2kGXa807Wdz3pI08=; b=SzJtZiILKSeFATLsvNzlboTOS62fp52LpHzN811SUD8zx76Ax/NOZeVokWarNSaqeg Xi7/hBIRZ/6kDIyFPYweCfYUS3mvBmBYdI/boULeswAm4MIgqv5n0Q0/T1L2i9spNhJ7 nGjbXf7zjDRMLoAQxU950xUw20pIWc7sazCRzUnOIgXZ9A2sue1W+zfzy325mCACg+3m VZDK2fVCajYjWjrE4Yan7c89oZto5RCL0RgyGt5qDSON30JKqNuU2FZ8yhQvKNuDqVil Vh56XiPBf2LbmOJ2KhPOU0GNROR21rl9+zjUz2etD9WhBayHxwWrG6MTqcK6KIEAuaMV cU2Q== X-Forwarded-Encrypted: i=1; AHgh+RpRRJjXLFoGYqxCJJdK3cSs1R62jS0pKA3kjnZNvFTG7JKBv0i+iJavT0G1PxlZSbTlcMf8vIO/WVUvrwk=@vger.kernel.org X-Gm-Message-State: AOJu0YziU5jQLoj3iKFk3DPndhuhayiJ/wKIMsgBE9GNg5Ah2lfKjwG9 KRzPI2moskFfHXkxZaVEQLr65hRjPw4JKS1fhNSZ9ztfC7jtG7xnlL58qBIix6g= X-Gm-Gg: AfdE7ckSunk3MxhmY7JmCaGS+xxySvqZ++5c/8VBxTst4xZ8F98lzc7iAQYLae73TRN 9rUeVoCcM45r/Y0XkdJiQaUFbgHfncDcnGfhmMwAkk7IEs5R1cLJBw4diCxgJgyYg3/YkzYqpmO mx7dfD4IwwsX+BDvSqT8P669h+pDtr7X6u0jvxXHjnSH8osHAVNUFazxjQUrmoxpukJkfrZH3EV E0aKa2K2xX25kzkx8HtgAfNh1uJrpUA9Dj7ZnFEK5Q1QITuQ0yeoML33ImWVWrMFAACE88k364W U3FNH7vDxQTMvNLSewFs/v1lcoXEggdY6EyMJq+F1gInTdcCwaZMDDpmq0tkyo3waBgQ3cUk0Sc ytGeoKPvKEx3xTfQekK0ZaL85L+thMIbedc1C3VIAgIHYdk65V7AjXWEdtySAesSJAOLAPExvg2 lJDTxbp1nx8g4zRmpUQX7e6KAP6jx5xBwe6ONX2U31qGn6i8yQpS4mMkUrgJWd7kpMOA== X-Received: by 2002:a05:600c:3143:b0:492:5e22:ef18 with SMTP id 5b1f17b1804b1-493f87ebbbemr104433225e9.9.1783959586422; Mon, 13 Jul 2026 09:19:46 -0700 (PDT) Received: from lithos ([2a02:810d:4a94:b300:ceac:ba6c:1653:e93a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f464a974csm554519f8f.18.2026.07.13.09.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 09:19:46 -0700 (PDT) Date: Mon, 13 Jul 2026 18:19:40 +0200 From: Florian Fuchs To: Thorsten Blum Cc: Ritesh Harjani , Geoff Levand , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Geert Uytterhoeven , Paul Mackerras , MOKUNO Masakazu , stable@vger.kernel.org, Geoff Levand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/ps3: Fix map failure path in dma_ioc0_map_pages() Message-ID: References: <20260711130931.740719-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 13 Jul 17:08, Thorsten Blum wrote: > On Mon, Jul 13, 2026 at 06:08:56PM +0530, Ritesh Harjani wrote: > > Thorsten Blum writes: > > > > > If lv1_put_iopte() fails in dma_ioc0_map_pages(), the error path > > > decrements iopage but keeps using the failed mapping's offset. As a > > > result, it repeatedly tries to invalidate the failed IOPTE slot and > > > leaves the already installed IOPTEs valid. > > > > > > Recompute offset and invalidate the installed IOPTEs instead. > > > > > > > Nice catch! I wonder how did you catch this? > > Do you have ps3 console where you somehow ran into this ;) > > Or was it a manual inspection? > > I do have a PS3 somewhere, but I stumbled upon this while reading and > trying to understand the code. > > > I wonder whether PS3 consoles are still being used? > > Not sure. > Yes, indeed, they are :-) But I'm not sure on how to test or inject the error path, so I can't add anything useful to that. Beside, thanks for keeping an eye on the good stuff. > > > Fixes: 6bb5cf102541 ("[POWERPC] PS3: System-bus rework") > > > > Looks like this was from 2007. > > > > However, the change looks good to me. So: > > Reviewed-by: Ritesh Harjani (IBM) > > Thanks, > Thorsten > Regards, Florian