From: Frank Li <Frank.li@oss.nxp.com>
To: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: wsa+renesas@sang-engineering.com,
tommaso.merciai.xr@bp.renesas.com, alexandre.belloni@bootlin.com,
Frank.Li@nxp.com, p.zabel@pengutronix.de,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v5 09/17] i3c: renesas: Use reset_control_bulk_{assert, deassert}()
Date: Mon, 13 Jul 2026 13:02:52 -0400 [thread overview]
Message-ID: <alUaPJMt_kCaMfWh@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260713130545.568657-10-claudiu.beznea+renesas@tuxon.dev>
On Mon, Jul 13, 2026 at 04:05:37PM +0300, Claudiu Beznea wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Use reset_control_bulk_assert() and reset_control_bulk_deassert() in the
> suspend and resume paths to simplify the code.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> Changes in v5:
> - none
>
> Changes in v4:
> - none
>
> Changes in v3:
> - none
>
> Changes in v2:
> - none
>
> drivers/i3c/master/renesas-i3c.c | 30 +++++++++++++-----------------
> 1 file changed, 13 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
> index c459e40fd5ff..915090d0ad37 100644
> --- a/drivers/i3c/master/renesas-i3c.c
> +++ b/drivers/i3c/master/renesas-i3c.c
> @@ -1437,24 +1437,22 @@ static void renesas_i3c_remove(struct platform_device *pdev)
> static int renesas_i3c_suspend(struct device *dev)
> {
> struct renesas_i3c *i3c = dev_get_drvdata(dev);
> + struct reset_control_bulk_data resets[] = {
> + { .rstc = i3c->presetn },
> + { .rstc = i3c->tresetn },
> + };
> int ret;
>
> i2c_mark_adapter_suspended(&i3c->base.i2c);
>
> - ret = reset_control_assert(i3c->presetn);
> + ret = reset_control_bulk_assert(ARRAY_SIZE(resets), resets);
> if (ret)
> goto err_mark_resumed;
>
> - ret = reset_control_assert(i3c->tresetn);
> - if (ret)
> - goto err_presetn;
> -
> clk_bulk_disable(i3c->num_clks, i3c->clks);
>
> return 0;
>
> -err_presetn:
> - reset_control_deassert(i3c->presetn);
> err_mark_resumed:
> i2c_mark_adapter_resumed(&i3c->base.i2c);
>
> @@ -1464,19 +1462,19 @@ static int renesas_i3c_suspend(struct device *dev)
> static int renesas_i3c_resume(struct device *dev)
> {
> struct renesas_i3c *i3c = dev_get_drvdata(dev);
> + struct reset_control_bulk_data resets[] = {
> + { .rstc = i3c->presetn },
> + { .rstc = i3c->tresetn },
> + };
> int ret;
>
> - ret = reset_control_deassert(i3c->tresetn);
> + ret = reset_control_bulk_deassert(ARRAY_SIZE(resets), resets);
> if (ret)
> return ret;
>
> - ret = reset_control_deassert(i3c->presetn);
> - if (ret)
> - goto err_tresetn;
> -
> ret = clk_bulk_enable(i3c->num_clks, i3c->clks);
> if (ret)
> - goto err_presetn;
> + goto err_resets_asserted;
>
> ret = renesas_i3c_reset(i3c);
> if (ret)
> @@ -1507,10 +1505,8 @@ static int renesas_i3c_resume(struct device *dev)
>
> err_clks_disable:
> clk_bulk_disable(i3c->num_clks, i3c->clks);
> -err_presetn:
> - reset_control_assert(i3c->presetn);
> -err_tresetn:
> - reset_control_assert(i3c->tresetn);
> +err_resets_asserted:
> + reset_control_bulk_assert(ARRAY_SIZE(resets), resets);
> return ret;
> }
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-07-13 17:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 13:05 [PATCH v5 00/17] i3c: renesas: Suspend to RAM with power loss and runtime PM Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 01/17] i3c: renesas: Check that the transfer is valid before accessing it Claudiu Beznea
2026-07-13 16:51 ` Frank Li
2026-07-13 13:05 ` [PATCH v5 02/17] i3c: renesas: Restore STDBR and EXTBR registers on resume Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 03/17] i3c: renesas: Follow the reset deassert order used in probe Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 04/17] i3c: renesas: Reconfigure the DATBAS register on re-attach Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 05/17] i3c: renesas: Reset the controller on resume Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 06/17] i3c: renesas: Perform Dynamic Address Assignment " Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 07/17] i3c: renesas: Clean DATBAS register on detach Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 08/17] i3c: renesas: Fix out-of-bounds access for newdevs mask Claudiu Beznea
2026-07-13 17:01 ` Frank Li
2026-07-13 13:05 ` [PATCH v5 09/17] i3c: renesas: Use reset_control_bulk_{assert, deassert}() Claudiu Beznea
2026-07-13 17:02 ` Frank Li [this message]
2026-07-13 13:05 ` [PATCH v5 10/17] i3c: renesas: Return immediately if there is no transfer Claudiu Beznea
2026-07-15 16:48 ` Frank Li
2026-07-13 13:05 ` [PATCH v5 11/17] i3c: renesas: Follow a unified pattern for transfer and command initialization Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 12/17] i3c: renesas: Drop the explicit memset() call Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 13/17] i3c: renesas: Update HW registers after SW computations are done Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 14/17] i3c: renesas: Organize structures to avoid unnecessary padding Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 15/17] i3c: renesas: Use the "dev_name:irq_name" format for the interrupt name Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 16/17] i3c: renesas: Drop unnecessary tab Claudiu Beznea
2026-07-13 13:05 ` [PATCH v5 17/17] i3c: renesas: Add runtime PM support Claudiu Beznea
2026-07-15 16:54 ` Frank Li
2026-07-16 9:33 ` Claudiu Beznea
2026-07-13 17:26 ` [PATCH v5 00/17] i3c: renesas: Suspend to RAM with power loss and runtime PM Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alUaPJMt_kCaMfWh@lizhi-Precision-Tower-5810 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tommaso.merciai.xr@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox