From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E840188CC9 for ; Tue, 14 Jul 2026 07:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784012825; cv=none; b=qC2ig+eV/1XiTsbT10e0FuHtzW1PAVSrAM6wQgMc3QhxG2SUuHGEhy0sj8czQNiCmZ2UcpBuiIHmEVDRNFyvtHvLe+bEAUBVlhHyTDNVdcWTA9GUUZ9J5bgUFLZ7m+4n1N9f1Lca9UXSXDyvNRNr9oAxrNnguUdbL99MO2SR46Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784012825; c=relaxed/simple; bh=/KzGKOlZ3bvNcEj7sYeqDf47jh7JWb8fyxkKwOKfcd8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gm324WRSQR/YjNl9rGUA0WSepF/WTQ0gsraWrYl3DYZ/7oRCWao+4udMxHuiKtrgz5aPK1NcdtueWz9kDSgSuH5+hgmZXZCQATJTGuUMeabyaIQh7PcWG4Pa6UvHhYU6GpebDA0s9eHtusSpTgcUeXLU1gqrf9gCeQkblyfm7cc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q21vrEUS; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q21vrEUS" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-4955cd5da3dso1656173b6e.2 for ; Tue, 14 Jul 2026 00:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784012823; x=1784617623; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=TuyYrGZ1DyNEfIN58XUvMb0/+UabFx7P6cZQIsqhIhU=; b=q21vrEUSBfkgQZV8KynGMpv24gIWKddIfth04scG0gwpVb5yQYzyJYUZV48hESJe6K NbkhhNZ357vXRvussqSGmIF+jij9y8b4rOh+EXCJyVN4i/QtyTJ42QTEXQevzQe/JNwE m0TX8SferYfc6dKPvRTlmtXEDQ0xuAsrQeAA1OP+1wSy9pk0/HPxuPCOlcDD4ouze4jI HmbofXGEpR3D9GVlOdSd+fb9zhWg87dJaPoK4VN1vOVdTBzTnOZ27LRTMJx2xMZsVqh2 SjoR1R0h2/p4Uu7AYcpjJrnpK/hKuns5KWRrz5FdNuaVBRiLwctkys0sLVaXd0gs6bHV H8XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784012823; x=1784617623; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TuyYrGZ1DyNEfIN58XUvMb0/+UabFx7P6cZQIsqhIhU=; b=UCm1TWv7s5UjKsedfzgXQs/tr6Qk0nFzU5FnR9VT5xRsd5PMFoRpSenxugf1vXkRte 5LOJLZuhKd8ntnM4DS0RJMfyf3eVcBK4A36uDXmJaHt8i2SxQ1xW2pRY2Vol4YQS764+ VXR7AQMkxtQc1GrDaJODSl3MgZAG/NPjvwBIxcuuu9t5yUd43vBLIVuQboC3i/v6whIv KgDoKFDDt1PCALSOl+AX6m+0J0vUEpmLHuWfd5SxrRBn/606dsYAfyJ8KPRLBcnlzlMy 9jy6zbYbGEKyAi4g3jTV8sgURzY31J156BqrvqyIqGiAXOELEl9YOPIXO8IdV+KvY2FL Wspg== X-Forwarded-Encrypted: i=1; AFNElJ+ztdmwOvM10bhQ2RrZmura4hJnXh3pazDbVn/f94fK92iipD7cdPnl7hEqnUwqRZEowa0k21Mo4ekOexs=@vger.kernel.org X-Gm-Message-State: AOJu0YysWXanyGknWjKRsyYvnK8gRgS4mozSKeBG/ADe0YxPskrY48fF KalVDOBZVXvUh4xv+DGRhiZweWjinupTQs7ljUisiEldiyZG1SqS0NUMzBKBMollIvU= X-Gm-Gg: AfdE7cm2JmpfIFDD04myRm4qB/cCp+j1GT1HMog0+eIvsPw5oUbYbZFMb0b7OAbwoBa KZfARGDrP+4xBsB8KQ9+7JPIbszxt0p/vJ4jIAZRKvUg4sJ4R4Wax0SBheqGuF3RD14Uns0+lPy E6xk9/JvczYk7jPAWcY01qE805yy62cKN3hn4pF5Py+sYi9yLuKmOWT/odscuR7dYmMft98cEPH sJiwZBkW8RdjpFuLuIFIK9fQSJV9E1nCZezwFgEWuKLI4bP6oq7l8HaFfY7dnpEtsB4lHVbt22F cpXmRCgieRS5vpL+Fq4y63Iv9NGbtxavBj2AOJk85aWgO7QKyXCQfCKXmIt4Y943ZMa5rtPOEet AaVEfN4VRrmPFPaFCujLKklHRMexUiiz21ySOlh7Jy9cgDHCeQmZsA1J0JIzl2Wolo3F9EEuseP 8qe9uI X-Received: by 2002:a05:6808:319b:b0:4a4:25b4:a0be with SMTP id 5614622812f47-4a42abc0379mr7380084b6e.2.1784012823154; Tue, 14 Jul 2026 00:07:03 -0700 (PDT) Received: from localhost ([74.80.182.78]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4a1ad5a77e3sm13498322b6e.6.2026.07.14.00.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 00:07:01 -0700 (PDT) Date: Tue, 14 Jul 2026 10:06:55 +0300 From: Dan Carpenter To: Alfie Varghese Cc: neil.armstrong@linaro.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: meson: vdec: propagate devm_clk_get() errors Message-ID: References: <20260713171644.691-1-alfievarghese22@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260713171644.691-1-alfievarghese22@gmail.com> On Mon, Jul 13, 2026 at 10:46:44PM +0530, Alfie Varghese wrote: > vdec_probe() maps any devm_clk_get() failure to -EPROBE_DEFER. This is > incorrect because devm_clk_get() can fail with other error codes like > -ENOMEM or -ENOENT (clock not registered). Hardcoding -EPROBE_DEFER > masks these real errors, causing the driver core to retry probing > indefinitely instead of failing early. It will not keep retrying "indefinitely". -EPROBE_DEFER handling is smarter than that. Fix the misleading commit message and add a Fixes tag. regards, dan carpenter