From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EB3843E4BC for ; Tue, 14 Jul 2026 09:22:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784020947; cv=none; b=WDwCB1KI8rCxfIjpspjm7aF1pxKopciZOqjhoz9wLBbWYrjtTDSz/olNzUbGnglARxk79NuJFBzETSlsyWc//M6XdJ9o5tMb/8uSNKKRES86Df7Zl0pfsV2eDM3wcshayhtNW376yjPHxXYEqIadqzOITC+UuRhi7BFxWSRl9Io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784020947; c=relaxed/simple; bh=uGWUfxnxIY0NKJB4tV1A7WYuOfk3qaqaeqns9woe9G0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C4ZUbGX3PukMj2kIflYR2xmZqGAcHdqjqPRjgNJ+CTkSbBx20fiJNRLMdhwfFl+VmryCjQ936E0afyjYSjYnJZDj/NMeRAx1JOOqe5/RGzChLS87hXZ30d7sPogPtvw/DAT0n+aKFUP+5AFEJC4TuiyUuYUwpLNnfTX7gGdRKGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=BhxCTw10; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="BhxCTw10" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-493ce08a75bso15902805e9.1 for ; Tue, 14 Jul 2026 02:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784020940; x=1784625740; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=a6rmzsH2Z8JYzFqIg2uMkj0gt9jdeZsll9yf1qnb10c=; b=BhxCTw10pMGuJ7cWbSUGb7gGi/Cj/kbJHXgvc42Y01vMdyqMjCLZNlelC/X99G4JJp q1wHIDQ3tQXEozuLxJPoyo25EONtRNBnpzdUw8FgZGOKS/XisSJ5ETUWgvEkHCL+n3h2 Mzl/YZKK9G8DkigQQpMMVYiGMS/evTk6Vn7UAxrpamUC+lCYFAOaQpImG6YCASQR3c4G rULR0Jk1UKH/RVvM8Sg5ToAnCnAI3XmEQ/IBMsySYN5Q2UmHcJdCkF5GEpXi/Jhu6DD9 ezfBrQO++TlIiXUX/fWX5334IdfmpjRxNODVthDTqYfuXVDc05WQLDESOfnnNuEcOO4a /WUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784020940; x=1784625740; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a6rmzsH2Z8JYzFqIg2uMkj0gt9jdeZsll9yf1qnb10c=; b=DeBfG/tQixjASKzqG4w1u8s3TVmIL0B4Q59FKNZeo7hADEJoaCdhUc4tekCX7fgzI2 7E9kCyAohVtwm8eZu+Do37OLPAlcQsyZzsOlrn/UHzi4KJEmZrC4APit2BUsxV+B9TvA uxWkfRozRIbYRBmRQJTWo7SY1bEgVx0ZKEgCVMlRR/vgJ3/HUsev2Agk1DFr8nngy8mE s5dWsTUbQCG/fB3YHrt4duxaR9cX7tI2ZelnWVV/iYncvLHiizOlKf4qKBojJY/Vq5ir ybxlIMquOrmk174hJW1X+cTWN7pr86PVwNH6+rjR8Gp1qSs2V8Z3Il+d7AmqmSQFz0KG rtEg== X-Forwarded-Encrypted: i=1; AHgh+RrR07REHKwfiovvUX8PeFPqTLL7OxgklspIsYSuMIb9bQhQ2fawitSMcRneDpT2FIfcSHe1x9wRpgMqbQc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2gHmqBqPQylNH/DiZIw9RQXX4kCT2v+FO9z6pUjjAPZd2z6Kj 0KAJ6jP+lk3jbuMFRCOwGg/tBR8vpZ6IRoqDFNU6nLoCflRrImlEZmgEVSfgBpuRnnNsckRSJJ1 dzvDr39o= X-Gm-Gg: AfdE7clQvxnuAswgSSWMIj3WhiKovUo41eodJ830a0nY0zB3Gd7AmRr0zJHMpZUPVlO VgPfO00P4mWzMuzZm1ufvEgPZI4DR+EyB1zl+bM5JHaNyHpwMg6ZxicEOoT/npN93uiL87PYBEs Vpd08bV4cSK0Q2XSYrnEOU8v+i29YWCPkyRthTLzuy6h//tfqVRS85we7bULkn1CNBFhO1Ii5Hy Fm3No+xErJFkQbKpn6ugdUWGDzL6T637hVp2VXIjLQH0ih5Tuww/A8Q3KzQY1TFGnIgR/pqoPzp Ojs1D3hx3iEyhX4JUvC6L/HPnoA6x+uJDRCaNj5xTU//IKyrwdro+mhQ5Ynt5OlbCJ45rrOg+/p FgIjyjuByfAgueMju+Y4WH3eZeQR2kqKLVJ59O47mNoill8ZRWy+ToYgc/m/Nh2FjnOHzZLu737 DcmSgkiOGxE40= X-Received: by 2002:a05:600c:524b:b0:490:44eb:c1ea with SMTP id 5b1f17b1804b1-495159060f6mr32557165e9.24.1784020940226; Tue, 14 Jul 2026 02:22:20 -0700 (PDT) Received: from localhost ([195.94.145.62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f2dd8376sm214271875e9.2.2026.07.14.02.22.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 02:22:19 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 14 Jul 2026 11:25:48 +0200 To: Andrea della Porta Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-pwm@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Naushir Patuck , Stanimir Varbanov , mbrugger@suse.com, Sean Young , Julian Braha Subject: Re: [PATCH v6 2/3] pwm: rp1: Add RP1 PWM controller driver Message-ID: References: <5171610d8bebdd10eea44bff5236502d765b5918.1783097764.git.andrea.porta@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5171610d8bebdd10eea44bff5236502d765b5918.1783097764.git.andrea.porta@suse.com> Hi Uwe, On 19:05 Fri 03 Jul , Andrea della Porta wrote: > From: Naushir Patuck > > The Raspberry Pi RP1 southbridge features an embedded PWM > controller with 4 output channels, alongside an RPM interface > to read the fan speed on the Raspberry Pi 5. > > Add the supporting driver. > > Signed-off-by: Naushir Patuck > Co-developed-by: Stanimir Varbanov > Signed-off-by: Stanimir Varbanov > Signed-off-by: Andrea della Porta > --- > drivers/pwm/Kconfig | 9 + > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-rp1.c | 435 ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 445 insertions(+) > create mode 100644 drivers/pwm/pwm-rp1.c > <...snip...> > + .driver = { > + .name = "rp1-pwm", > + .of_match_table = rp1_pwm_of_match, > + .pm = pm_ptr(&rp1_pwm_pm_ops), > + .suppress_bind_attrs = true, > + }, > +}; > +builtin_platform_driver(rp1_pwm_driver); > + > +MODULE_DESCRIPTION("RP1 PWM driver"); > +MODULE_AUTHOR("Naushir Patuck "); > +MODULE_AUTHOR("Andrea della Porta "); > +MODULE_LICENSE("GPL"); > -- > 2.35.3 > I didn't get any feedback after I replied to Sashiko's latest concerns, which I don't think are relevant. Can we proceed with this patch or are there other concerns about it? Many thanks, Andrea