From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF0873A5430 for ; Tue, 14 Jul 2026 12:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784031337; cv=none; b=O7MvbO2G80ou0w2hC8wnKCaCEGb/WwfFtyUVdgQfRgF+ZmVhmg+EiZdOMaA4Jy7p8FeWdbX4kEp56ikt5bEpWLi5FOYOT/l9SkK97x5GB8HXm3sNoX69SnjHZacYpyFQumQ71Sw01qNfsfYqTuB4xyR0IFfcBJ6jW8fMCHvQfOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784031337; c=relaxed/simple; bh=W/pTqIwe4xUNI9+Bwfc1wa6dgdLWycDVCa4WxTfAbsU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MAEFJohHIQOzO5vQ9E9lfR29PL0yGSOHjtBKucEPjn+LX+G1rDa48rvG/hFJsUtyNDRmtcAsOHqCZS4mIN5nd6u1XVH+RKAiSOYO5pTEriz5AQY0a+jUrVQVDFWyKb6Ier7vo5fZofPsM3vSG6OUwfzGOug3FsolHO9lft/nn4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BCwC3Yce; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gznLFfNG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BCwC3Yce"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gznLFfNG" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66EBO3tf447794 for ; Tue, 14 Jul 2026 12:15:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=EbjabJKfrypzaGJPXCP6Zom0 cRMqI1dN1ZRsHgXVLeg=; b=BCwC3YceSfwa5tCq0n8uf1ZuEWzFe+jcfoePJfUA 6ns6PPCOYID+3zmLzZ8iioTqcs/5V3hTiZEDX+3Ejj/ojYTb3YxMnDbmGXXRO9ZT oTfc/ZsJmtWzfUybVqva0uFoxDTQVcmNt5WgAmC2oNA92NC/rBbhoTDBD3OrIWcf 59eckJZFwXgmTTWroi/hyhqcjwEO1FVT7WYq6P/iikr6SChYavatcyVRXQ2xoYHW T1EZ11BwMgBlNTnmgZmThZirGieP4xYWXUPP0XCgRYntvndYr5cJIbwpxBZnEbEY 4LAfneq+4ISCv02BNnIkOP/li/HeJXpBWcbrWNMT7LmjLA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fd44jun6v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Jul 2026 12:15:31 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3823dcc1647so5640330a91.3 for ; Tue, 14 Jul 2026 05:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784031330; x=1784636130; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=EbjabJKfrypzaGJPXCP6Zom0cRMqI1dN1ZRsHgXVLeg=; b=gznLFfNGPRatvWcSaP/BbxZsR4yl3B5SO6F+msFiGjljBZUJ/jUhuBg8OOS7V0MLWx TqFRYvBrMg+sIfpcGeXTU41DW72cQ7QVnYQubzLZT4oDnHNiKkiCZMD6axVfAGPQEuFi k9A3GPfchqPLPSjUUzDv19H92XMZl1aMZTo2yb6gSiC2oGMrmFJJaq57BqWGdpRbAsiC OAhh6X0BtSPi7NW6uXXZDE9Lavm0IxGoxGXWqmujbGLHguxkfbmDMqXoRztZ1HFHGz93 IvyD5yEtCt2sDZAjKYRqX3FOTdHgmhJbBiulgJ4mqyEJ0jwK917+NTL9h0qxyJTdDj+h S1Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784031330; x=1784636130; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EbjabJKfrypzaGJPXCP6Zom0cRMqI1dN1ZRsHgXVLeg=; b=ni1oPEkbeFCEidQ3whXlBCTz0u0Dvx6NXupPurmpsk9jAh9kQQZ/vNV6weMm8QsDaY cDPyiUjqdrco5SruzvMxH9v5iw3YdGlJNRWSgEf4B6S7LNHHBgyGrMzGG4Tj+EeFW8FB mJSik8qJjyKUvPTFm7ZamwC/2JZBrwHL+RqxERq4z5fMm6+LNwrBJSqoVQUpRUFjdESS rlZun0lWcSOiI6KFaE5wUILPCafFg8G0el9YxAldPPUma9Gud0cfBjckVSBY0lcmtg0L tLJijrWsDqtHvAJ+oZeeRCVgr59fyj/8VlKGN9mgNUT0IZd6SIOz5OXWYcgL/5JiVrYy iQ/g== X-Forwarded-Encrypted: i=1; AHgh+RoYThAQeInsdCzJO09TuqTxfUT2UN9r+2Zs+7wCJrGb3uGmcZbixYwy1QQLgBHU2dHzqTCLUD2zRoKPEjc=@vger.kernel.org X-Gm-Message-State: AOJu0YwOIIR8BdAp5QsmTxYKzo42PMKojcJ3GY2QY0NpI3m1tZ93fQ4f tqkONRtp/MZOc5fifMtaiCy0CQRjzFwV22JzHdInub3ZO8ENgi4oiuXO6Y692kVaO/ymNYPp5QK HS3rB7wMUWjaRLVqYV1i2mPk4mJn6lmkc0IiaFG/PRfCRrXvVFQNaH5Z/WBbiCPjVYxUkAPqbyV 0= X-Gm-Gg: AfdE7ckzP1W3DN/5YABM3Iu2ReoDuoAbV8J4PuRPqE+OckUbQFeym2tc4Ao4yex0wqc LXVLxa3gLLE6L9VgRFx3Xey/hHiR+1nMzj0LAWrVO2naQE6JMCwP1HAKcciFJ9JsVtUNeX711iX /7IdatGoqL4gdYLmUwvgcDn1GzZlDfJVNLlYhomxeBDRnmK55h47iZVXxDqaSdMaLd8FhlniEGA jsPD8DA13jhYzjeF7/29Kf/w3OYHnh6j531RvlHkUWRFildGJeBSz3+HlEKtJkSMQSOrHDYilbR 7gWTovODoOXcqFC16Bo1K80+pe0vAYjqCUWSpZqsBLJxR/I1yDKRxslKgPj6LpmVfzhIY5gALAx CQbwiDMTGtDNG1cgPkh00wtTYPZZg7iCMsjwYlg6MexUU3f116py6pg== X-Received: by 2002:a05:6300:218c:b0:3bf:6c08:fb82 with SMTP id adf61e73a8af0-3c1109ecd0fmr14656797637.50.1784031330520; Tue, 14 Jul 2026 05:15:30 -0700 (PDT) X-Received: by 2002:a05:6300:218c:b0:3bf:6c08:fb82 with SMTP id adf61e73a8af0-3c1109ecd0fmr14656752637.50.1784031329973; Tue, 14 Jul 2026 05:15:29 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b9a67c217sm22222147c88.8.2026.07.14.05.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 05:15:29 -0700 (PDT) Date: Tue, 14 Jul 2026 20:15:24 +0800 From: Shawn Guo To: Bjorn Andersson Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Deepti Jaggi , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v5 5/7] arm64: dts: qcom: Add device tree for Nord Embedded variant Message-ID: References: <20260709132013.4096850-1-shengchao.guo@oss.qualcomm.com> <20260709132013.4096850-6-shengchao.guo@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: Svk869wwkA1rexzSIUnrcI3U9Oq26UqA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE0MDEyNyBTYWx0ZWRfX9I9IOe8jIJta yP4gcJzFhRzkXn8Y6sIBV64GYi1rr/9TGru51snRSl4jwnVhhb+WC5ctU8Piq7KP8ebRi+S2ITT BoVYgqNmmgjceDzr/zytMk3bIgCesm24A/sSp1UShD02JxbxJZXgbOOvDgMlCHNDADxDDKh2277 adm8fDwdWD1B/GWvuhKkywZWBrN2GGZRX4x2f1FLAZcu655n2PW9JYp9McxqgFz2YY9xjh+N3zT L4kbmeviHWql7w0Bvp82BpJEkjgB6Xh8EAowIIFY3esUqND/KWpSwqRJdO3AneRHp7kKpCDpBN2 hq/wngpv9MZ/yxHFaeDa8EsG3YaE1medaZYzWlbLc0tIYdX8I3GiN536/qW3TUxgOnNbyfm+VBU f2OGky/J4PsxehghEwnEXInCNmV7JR6qKcP5E2i2XCPUHr26s2fB/KIGnxzvX+o/zDRwqyn7uLM fmfQIz0ss9n/tHt9E0A== X-Authority-Analysis: v=2.4 cv=XonK/1F9 c=1 sm=1 tr=0 ts=6a562863 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=EqI0jlZnegA9myTLE5AA:9 a=CjuIK1q_8ugA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: Svk869wwkA1rexzSIUnrcI3U9Oq26UqA X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE0MDEyNyBTYWx0ZWRfX/M1y4kQsu9j7 3tl4wWz+P3dDNRTRulCK4S2ijc4BWdZI/gG/40u/FnBlg+dddTyj9uWStzkZO5We2c2TzncipL6 7AcCNdGHTkEAT/wdnsg2JZ6NB4aagWo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-14_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607140127 On Sun, Jul 12, 2026 at 10:39:44AM -0500, Bjorn Andersson wrote: > On Thu, Jul 09, 2026 at 09:20:11PM +0800, Shawn Guo wrote: > > Unlike the GearVM variant, Nord Embedded variant has platform resources > > (clocks, regulators, powerdomains, pins, etc.) directly controlled by > > Linux. > > We're writing DeviceTree here, our job is solely to express the hardware > and firmware interfaces using the agreed upon bindings. > As such resources are "directly controlled by the operating system" - > not "Linux". Indeed! Thanks for the suggestion! > > That said, this is a good structured commit message, starting with > problem description, nicely done. > > > Add a separate dtsi file extending the existing top-level > > nord.dtsi with nodes representing these peripherals as well as describing > > how they are wired up with the already defined components. > > > > Co-developed-by: Bartosz Golaszewski > > Signed-off-by: Bartosz Golaszewski > > Signed-off-by: Shawn Guo > > --- > > arch/arm64/boot/dts/qcom/nord-embedded.dtsi | 1731 +++++++++++++++++++ > > 1 file changed, 1731 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/nord-embedded.dtsi > > > > diff --git a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi > [..] > > +/ { > > + clk_virt: interconnect-clk-virt { > > + compatible = "qcom,nord-clk-virt"; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > + > > + mc_virt: interconnect-mc-virt { > > + compatible = "qcom,nord-mc-virt"; > > + #interconnect-cells = <2>; > > + qcom,bcm-voters = <&apps_bcm_voter>; > > + }; > > +}; > > + > > +&crypto { > > Just to document my concern here as well, splitting the definition of > IP-blocks like this across two separate files makes it very hard for a > human to reason about what the actual platform dtsi looks like. > > If the benefit of this reuse is worth the added complexity, I'm > accepting it, but it does means that I expect that any changes to > nord.dtsi will be tested across both models! That's a reasonable ask! > > > + interconnects = <&aggre1_noc_tile MASTER_CRYPTO_CORE0 QCOM_ICC_TAG_ALWAYS > > + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; > > + interconnect-names = "memory"; > > +}; > [..] > > +&ufs_mem_hc { > > + reg = <0x0 0x01d44000 0x0 0x3000>, > > + <0x0 0x01d60000 0x0 0x15000>; > > + reg-names = "std", > > + "mcq"; > > All other changes in this patch directly relates to resource providers, > why does the UFS controller's mmio ranges change? We can have them in nord.dtsi just like all other device nodes, but we will need to delete reg-names from nord-gearvm.dtsi, since qcom,sa8255p-ufshc binding doesn't require reg-names. @@ -2907,5 +2907,6 @@ &ufs_mem_hc { compatible = "qcom,sa8797p-ufshc", "qcom,sa8255p-ufshc"; reg = <0x0 0x01d44000 0x0 0x3000>; + /delete-property/ reg-names; power-domains = <&scmi3_pd 0>; }; I will do this with v6, unless you hate delete-property. Shawn