From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] iio: light: opt3001: split opt3001_get_processed() logic
Date: Tue, 14 Jul 2026 20:04:10 +0300 [thread overview]
Message-ID: <alZsCghbqDBF6X0d@ashevche-desk.local> (raw)
In-Reply-To: <20260714-opt3001-unwind-cleanup-v4-1-7ebea805bfac@gmail.com>
On Tue, Jul 14, 2026 at 05:36:48PM +0200, Joshua Crofts wrote:
> Split the logic inside the opt3001_get_processed() function, as the
> current flow is hard to read, mixing IRQ and non-IRQ code blocks.
>
> Separate the IRQ code path into its own function, same for the
> non-IRQ path.
LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> ret = i2c_smbus_write_word_swapped(client, OPT3001_CONFIGURATION, reg);
> - if (ret < 0) {
> + if (ret < 0)
At some point consider dropping ' < 0' pieces for the i2c_smbus_write_*() cases.
Read cases are different, of course.
> dev_err(dev, "failed to write register %02x\n",
> OPT3001_CONFIGURATION);
> +
> + return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-14 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 15:36 Joshua Crofts
2026-07-14 17:04 ` Andy Shevchenko [this message]
2026-07-15 8:09 ` Joshua Crofts
2026-07-20 1:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alZsCghbqDBF6X0d@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®