From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2C746EF88 for ; Tue, 21 Jul 2026 20:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665327; cv=none; b=E7ttGVCBo1SYzlJXKe4kZd09wPP/cK1jn6nVxlORX6amj41OOjRdKYqXkas+tT68qdwXEJzPN+j4gxiMSnaLZBfBlt4u+hl9RrQZX3tPTf1Ri/VEmVm8Z9fvzNsUrVfk1Fdp55JSKUilKaVt8qV0ls3QrqTQoncWrf5K6FXOwgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784665327; c=relaxed/simple; bh=8N0ardGHDYbJCcGaX3xW1f5fMzokeG11GJ2kjqZSrSI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QKcoStp9uXrWS9tOu37hNwZGQENkKAby8Eaj3rrqWpKRPqmuCpf0NnTUXCyp9ooZKq8HoydWtmUeVqhe1R7ofWz8A5FXnNBoT83ezOrijexi7fEht4VGe2IiXRW6iG8+7dw1sFoPtj6DTDKIGd3SxmVe/3oDph6Z9efBZOga5JY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mLuT6uHJ; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mLuT6uHJ" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5b2aa3be376so169278e87.0 for ; Tue, 21 Jul 2026 13:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784665324; x=1785270124; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=pOPCrZROWsDyG1I/C6+7cS4PhF0GrOUguiAaKjDuy/g=; b=mLuT6uHJOQxw91/GIAIKYeUIptYVEdbNyoFygwuHVM6cR7S8ke0rCmurZ/jkbYFiQ4 8+e+ctwmpUkW5nZ58BehFtiKMaRTTgkEHqd2I2ucUDaONdOON7HwvZLnXIY973NcBQid z7GC/rtkuIfoRtsjar/PJFtTvS7ybRMWvRafPdAzufVrrWrm1/5t/6rfELayhyLaQtyQ cu3VyrYQJNsMzYNOKaLA91QHpWJFzP5YrN3npp8xWLB2t7qFK6l+vG1qkGzAOHzE7G9+ WRi34IFy0j+QqYyxCKNS4EDE0iTY3ccDTN5q24WaKHo748SgtfryNI6RGBIPjffI3nE1 0mJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784665324; x=1785270124; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pOPCrZROWsDyG1I/C6+7cS4PhF0GrOUguiAaKjDuy/g=; b=bjuWtQTxFRSxehtWFDXqVxXVlwK91TvuxwkG1/YwgwJnoZ552oFCs4aHWWHWpDXbs3 IjogBTlRp9X8glfVczOz2IE+J/uPeItoeJaFC5w9Z8l0HlUv3IHfFKI2vkLX/NbONk2H AWB0BAGoFr2Ik5UOkmhNFHmYYCzBxpBbD/62zTjZt19kZKtWk4JfXD1BQpz7ckX2/qyS YkofFFj1FsS4dLBpRS/Ad7odi+Ndw1XEvS7XaEeZH7nAlkkSO6E3j5t5XPGmstlT/YZe CrPsiIy5/Wo97z1vKumyeGxokTnpxoe6qgCACazSDoDR0RA7L3nyNKtRPIeeqE37UN+x z98A== X-Forwarded-Encrypted: i=1; AHgh+RoyvBXRhtkMeJhSe3NxV2fHxu8aHlRko7wcxl7NUqplyMwFjn+hj+j+ji+WOslxzcl9L270BuWIzMer0pY=@vger.kernel.org X-Gm-Message-State: AOJu0YygyupAr89KWQDTFyUvuSAKryLzkSwWrQegIRWk82/Lo6ZInTB3 OCUVRm8nZnEPjid+Oax/8SYBawpmnda64AUQCS/dTIYBTTndRjeW0ibx X-Gm-Gg: AR+sD12RZZvHJANAPOw+Z/it1jlF0+K8F1P32aoqAOmkHLOtwcnkg6/glDY7hJtMb6u IP71nwHiBP7BTbIssbBBsxNP6a3Kdr5es9FJIQ2j4zyNkZu0HLXB6oa/bFreANCgNBqaZSta0Dt /uFC11PaLQrfElF0URgvjBGtcVxfVpe5hGnUDZFe8tRi4GmGHQGQCz/KauK+2IKtAE11LXBfTLP ZcGnD3BkjfcnlCr9FV0y2QBVsR+MGJtmqZEdrPtDkUqb1FXxipEqLZ3gSz/g3tUOD+J9p5uaujr fyYJAebS4HMXixLE4ixxTtAVHoJS/PmDVB8tOZmR1xGFTIMcqBLEWC6CUMZp8uyaH/NhUS7aHXZ Fhdgf+C8Sb15hU05LtsFWLCmMQcVF9jEfKGdQi8rMFZfdCfkm5jP6HsH2gUPI88zdhjgOklD/eQ NPEB4cknMizPqhdkRg X-Received: by 2002:a05:6512:3d03:b0:5b0:1852:936b with SMTP id 2adb3069b0e04-5b28fabeb58mr4630637e87.59.1784665324038; Tue, 21 Jul 2026 13:22:04 -0700 (PDT) Received: from localhost (soda.int.kasm.eu. [2001:678:a5c:1202:7b92:9ac1:b9ef:5287]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a9d30758sm99909e87.45.2026.07.21.13.22.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 13:22:03 -0700 (PDT) Date: Tue, 21 Jul 2026 22:22:02 +0200 From: Klara Modin To: Rosen Penev Cc: linux-wireless@vger.kernel.org, Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCHv2 wireless] wifi: mt76: fix MAC address for non OF pcie cards Message-ID: References: <20260706232857.807044-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706232857.807044-1-rosenp@gmail.com> Hi, On 2026-07-06 16:28:57 -0700, Rosen Penev wrote: > If seems the check for err is wrong as the proper macaddr gets written > to from the EEPROM itself. Meaning checking err from of_get_mac_address is > wrong as the proper macaddr has been written by this point. > > Reported-by: Klara Modin > Closes: https://lore.kernel.org/all/ajRmlyx_AEGybykL@soda.int.kasm.eu/ > Reported-by: Tobias Klausmann > Closes: > https://lore.kernel.org/linux-wireless/30a90714-02d8-45f2-a7f1-4cfe0627d50b@skade.local/ > Fixes: 31ee1582717e ("wifi: mt76: fix of_get_mac_address error handling") > Signed-off-by: Rosen Penev > Tested-by: Tobias Klausmann > Tested-by: Klara Modin > --- > v2: add extra tags and target wireless > drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c > index b99d7452800f..afdb73661866 100644 > --- a/drivers/net/wireless/mediatek/mt76/eeprom.c > +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c > @@ -181,7 +181,7 @@ mt76_eeprom_override(struct mt76_phy *phy) > if (err == -EPROBE_DEFER) > return err; > > - if (err) { > + if (!is_valid_ether_addr(phy->macaddr)) { > eth_random_addr(phy->macaddr); > dev_info(dev->dev, > "Invalid MAC address, using random address %pM\n", > -- > 2.55.0 > Ping. No one seems to have picked this up yet, but I suppose it is holiday season. Regards, Klara Modin