From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64D6042BC4E for ; Tue, 14 Jul 2026 21:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784064598; cv=none; b=RBDVbUGpZYkzuBWxEiuYg+Uvb03Cn8LC9O073jKk0gxRJSXOINcrx7mAUC2PDtEHwTQJvfy8H4AZCVq8KzC4XKeVHdPg1oaT7AUEPQHlzQWNZONm67Lq8j2CPRn2JhdxTaj4qf5Nz4L80NqOz8ODeW45SO64pZg3MlOJnvJj1dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784064598; c=relaxed/simple; bh=ciVNjfttApZ3P/sDlY6bfVf6naQ/j+tTI+9qautLJWg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ezPqLuTmvkRcm8OupSqRUIheWvRTBdBAfawYeeidg48+P7GX4vYNB8z0hLIZio9zt+iKEnix53LSbSNQeaqvOqGYP8Yw0KvyBYpPDNth6upRtV8eprj1EyqEB4xWyRPoPtBJRcX75+q93WtynB5vyCrJnAGhOesuwYXsyw04QUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=WwjHnaLi; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="WwjHnaLi" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47df440fcd5so2666590f8f.3 for ; Tue, 14 Jul 2026 14:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1784064594; x=1784669394; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tG5xu9XUyqIVx9AETRBq9Z5/aY+YTJq5pdj8yqHRqpU=; b=WwjHnaLiy+31iuT2VoRyQKnGqhUuMFQEj9Jqsb8fBcJ9yNul+uj97DQNaq7+aLyWP9 zgAkDUvR9HhxGq58WxQRM0kgwshgXO6Ngnu4S32j+rYkYQuXlb0LLct5BQRcgObceJ8A R075d7Unp6FBGyoKohz3ZewKS+6Cozu1Hk/+j5hfWwRlH3OBpBDJ363BhetZnc3U5w7J FuI0c1KSykuJjntALo1wXpb6v3dY/hMVzcuxCLVccqTrJ7xCMHX/EoliVRdobQnpc/Iy WDUHXP/7XTT/aodjs2xiuOhTWx95PJA4ODQHB9hR1/e7bykvCp53Gs6uD3a4vddGA/Kl fbQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784064594; x=1784669394; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tG5xu9XUyqIVx9AETRBq9Z5/aY+YTJq5pdj8yqHRqpU=; b=G+uD5H5oqW/GfcMH0qbPMw7mgjstvytu4aE68KDwdp2r9WeaZ12oUfzVWn6gmwIZSB N08HulKaFYzcIiBBooMaAySIJhaFifKFgU9VdxWiQ8Dt5flKJkWuPuhOLC+bnfxOhktR BP5DI4It99FhR6z4WbKvJU/+kPKl53mtAbMVr4Ofdc1kDWUsixdb0dv22JNCDPBtXucY uTmkKhN2Hr0RuhkiNo/g6xHdnRDkOfVaKwROktGOJrFsEKdJyrnZFKrSSI8s4XXciUjW FsDJZvjvS+iMLHQmg7ZGtUolA4prgf7Au2Ew7OF71Vo8scA9S/J30hw+H4yfvVidlVWb iCJQ== X-Forwarded-Encrypted: i=1; AHgh+RrLlAGMu33g2i5N0gUgu22Hscyp/sRxNabgTdwKXuhVPxqmouwKCzfsJaBnhEDvw12jUDKHaBo8Shb3Rkg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxhb/ohXdXbcb7BCSI8jjk0nk/JZUMcsKv9kVelbuLsiQEgex6E NLo4nJNbEE7SpLpLwXYFiUzqt4rZvEQ/b4sE0vAtrf8R/rUKOY7cZyqbodCGgSiDgfw= X-Gm-Gg: AfdE7cn9VIPiX81LTfAGoVWBE4Z/LInu8/sWdjDqsxKXCA9WEZeVo0cij26GTsvnh0n HY0+/rDh7Ul8uwrLQGcZhqzJ+t3h7k3/xa5pYIMRY4wi8hqiQvEQGp7tttuUba6rVJAi3XjhN1i /H0y8BoYH5h11MZOzeWNR3svxyy9UgIwQgO0+uojv1h578G9osomNbQQPdrqD9MoS3DKTw057cn LIw8NGdyX3aJuH8ewGorGhbWo5Gkfc6+mNYAhhI4LHoWqW9pIrGXkAK0w1J1YETAs9T3AZ9FYGO jQY+8NKQmPESjmvQLoWvYFLgQoX2bX6uhXGtWAT5JmslG1AzxG3y3VuYvzAe2TqDWPnTD1FUoFu lACZEuqXrOTh4dccxJ2lfyfzykMgHoRFtifuVbO6q00RHpbsmi3s5XrXQHQIs3op8mqlGXANOos ITN6J/pymuvTJylOf3lw== X-Received: by 2002:a05:6000:2c04:b0:475:f100:3603 with SMTP id ffacd0b85a97d-47f4fcf193emr108406f8f.50.1784064594560; Tue, 14 Jul 2026 14:29:54 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47f464a974csm13070062f8f.18.2026.07.14.14.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 14:29:53 -0700 (PDT) Date: Tue, 14 Jul 2026 23:29:52 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: MANNURU VENKATESWARLU Cc: krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, n-francis@ti.com, s-k6@ti.com, bb@ti.com Subject: Re: [RFC PATCH 06/22] memory: ti-ddrss: Add MR4 temperature-driven refresh rate driver Message-ID: References: <20260714125557.3304305-1-v-mannuru@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2mkn4dfbhj25cdbs" Content-Disposition: inline In-Reply-To: <20260714125557.3304305-1-v-mannuru@ti.com> --2mkn4dfbhj25cdbs Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [RFC PATCH 06/22] memory: ti-ddrss: Add MR4 temperature-driven refresh rate driver MIME-Version: 1.0 Hello, On Tue, Jul 14, 2026 at 06:25:57PM +0530, MANNURU VENKATESWARLU wrote: > +#include > +#include Please drop this header. platform_device_id is provided by , so the explicit include isn't needed. The mod_devicetable.h header will go away soon. > +#include > +#include > [...] > +static const struct platform_device_id k3_ddr_mr4_id[] = { > + { "ti-ddrss-mr4", 0 }, > + {} > +}; Please make this: static const struct platform_device_id k3_ddr_mr4_id[] = { { .name = "ti-ddrss-mr4" }, { } }; > +MODULE_DEVICE_TABLE(platform, k3_ddr_mr4_id); > + > +static struct platform_driver k3_ddr_mr4_driver = { > + .driver = { > + .name = "ti-ddrss-mr4", > + .dev_groups = k3_ddr_mr4_groups, > + }, > + .probe = k3_ddr_mr4_probe, > + .id_table = k3_ddr_mr4_id, I'm not a fan of aligned `=`. These tend to diverge over time. And sometimes they are not even aligned from the start ... If you ask me, just use a single space before the `=`. Best regards Uwe --2mkn4dfbhj25cdbs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpWqkwACgkQj4D7WH0S /k6Ahwf/b81Vv5hkw4FybxhsgdUe5wRo3ENmjomE25XcR89z6XUIZtiVMfJFPkpo ob3KI0c4+bTcA4ClDIDTS/g1H9V6RTolyo1OF6lQKz6ZZ+IP2oKBdIGXIKCqk/x5 okV1ajvlpDT+DN9RXTy1ObvjXfLCbkPL4a+CSqONktVR69fJWkRsG9kCT2tug09p 9PBYVy0Vy10Ti1ZnNvZw/+9+LdlXFAxauM2/Mcq/1IvRkWP/YJJrLlttziAbYGg0 BqKW9p2CZzWVYkv3c/erWIe9ZOdgI2C7zlP+Nn9pBxXtHlpTaNFqK8AEKlfB4yJH gG5rmrbz6NksjCfJ12/W3ew91DesPw== =CCWW -----END PGP SIGNATURE----- --2mkn4dfbhj25cdbs--