From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DFDB3AFAEF for ; Wed, 15 Jul 2026 03:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086684; cv=none; b=GWoG/e3JOGJb82F95rV3EmKo8QFE8e1fanyQF4sXXU4gJ0SJJw6wr2yDZHqXLUaIkxpoFDVTeaqCggIfWV34hIeB1YpSrBipfcYJQVC/er2mclyWcFn9Yv9yluwV3I3e+2ofb31g/TnnURNG08ae/rm2BjcGET/es/HAgs8+6S0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784086684; c=relaxed/simple; bh=oyFkWMNa9fRt7sFWFB01ejvmlxQL3Rm6WRjhlInZEk0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aqpsPWTWw2Re56UzaZWVujGlb1oiLA8FtjnhTWU2pcgh2nDSmMeHVww3s75FLYBpqoXV9WbRIX+5aXZXs1w77OfgU4GJLA/B+/VQWtcyn8w6QdizXO70ga0PM5UYrueBKW/BUUIzStlKZSh0KE9xQML//s7DXexoCZIuxnLjTBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cS85yIjy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XLMUqEQj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cS85yIjy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XLMUqEQj" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66F0IFd21921977 for ; Wed, 15 Jul 2026 03:37:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=7e9IbSuaSjhO5SzNL0GuiEie GTLyIZc7yOYtJCBxBik=; b=cS85yIjyVOXE4H8ASxvmvqe8Xyd934MpiEl4tqFw qasjj9YLFaF9bGV+QO8BOOu0DUtBanN/pRvWRj4ycXEizGSD5To4DV2n3s0OoSYj lMpo9dFlp3wRVUo+oKeL7LFKHpYanJNpJ17PaofJO+9LZ76lelElo0poTWMHZfBb jHvgXXm1w+KELX+wv0VPFlcvpal2N7WO47dSntGSmt6zH1Ycs7Bj/r0y7N/iOLBO leDl5LMjTvOGrfXJtQ8LbKABcreP+AVCLjrfH4zFOoHszzJB/SeNcfQe+XMALvug aa5xuG/rErcXEgZE8YvqB0MQeKNW8C2H+ZxogUQOCwSv9g== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fdmkk33x0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 03:37:54 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38dbf293831so3805763a91.3 for ; Tue, 14 Jul 2026 20:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784086673; x=1784691473; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7e9IbSuaSjhO5SzNL0GuiEieGTLyIZc7yOYtJCBxBik=; b=XLMUqEQjTRFieV/WsbxC5KiDImZDklqKeOIL308oUetVT0ABf8cKw8N3VpyFNflHUs qRiCeaNpB6gMAhwB1GI8l4IdNEjjKiiPHed4kaDXToiY4e2Tj5f4nVpVIt+i8StBjkfQ osm/vmB9mhnGFvVhHhwNC5cpdGVeYeoXOC0CgMVIENBjglCH67L7kQ9+k39h9nLyV7G4 M0nrR0TPlrXFmkiDHolSAXV5OJ/1GJieMrH+HozsDKUOQofPdUqrR6orL1JSpaQTjg+Y XMj2TXzpbMFPtJxnUMfWIpIyArYmkzgplxe5WzaRxlznc2Ocba1uYLgn3WGGbi3FV3Jl Nkrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784086673; x=1784691473; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7e9IbSuaSjhO5SzNL0GuiEieGTLyIZc7yOYtJCBxBik=; b=m4GFgBGcNZDQQq6v8imRVOAil4tOXCh7JtHZMNLz9uY2BhGaanhQ33bOQPCtb9NkMi n0NqkKLcst9ZMXrFwDlP4/xV6k+xLr3bE0r/IdDwYGl162k80mIn3hoQE0ptalUFmkpL cAWEtGqeZtXUVggl+Py+n2dX4ckQa92VWdxmvhLxsowyJ0KTT0RvwjQzFOMd12FjesEO huG/pi8yVnzAKt/CqLanblWFRGBdW/s/X6a60x/0gxzNLQY/1229xOsAKGMpxziJ11pf hT/kq0MBY3yAaLoYE1cSGBsVAYYBGiBT4wRJ4n/tDwEXOgOVsiLTslcEvdJS/3WbUaiE FpwA== X-Forwarded-Encrypted: i=1; AHgh+Ro9kBXVZrfRIZL1ba+ymKgcTrBiq9QBEDWiVJ3w34000wz0JzA0HbHHGd/smGp2dSQLp2Rnn83LAK99i4Q=@vger.kernel.org X-Gm-Message-State: AOJu0Ywd1wQuFZQmXLlqbLeMGlp5gL+tMXafTJt6mNJ2Iav1vy95qdGQ 66k4x5hVqcuBrD2dqPR6ZdfnhSqk++zEnjwrxgdL9usS4G7wz+vUo/Cqyqssni3tR+f49bS3J1v fXK7yFQFW0guwV1ayg4oL5mzGBJEAoW2R9FLFaQgkx9mBOMdWl4CX6I5CFUM1LInLxQw= X-Gm-Gg: AfdE7clZTsrfED+4D0MZ6UNC+/d3+p6y5t9eY6X3zt8jVPwmXPZCCTYQ+NkD17i5+lm wzAx/2MhPSaXz9hBwCI+mAFtez8wITJ/AnGjXyOReqONxyq85bga8/uAidbZ32n914Mobl57WtE cZ4pbVBUVXWH1QjKVFXmWgPf6Eear9lapudHkXYtGAVGWfgp2dOwRrt6TbSfhcCy+xeMxZfaTvQ vuZWkXCR5R2JUZXixuZmmiyigKokGu6zZsbQ+mG+g81X3mc6yfJORay/2Gb8LDr+QRg/9fEVcST s+3nQWWPUdnW60rnWDMLQc6JWdaHHNor7G/p5p6kGGY4AuMSgTKAu7hxpQSXzq0IqSSRcMsP7BT 5nICuthhgl7srHRurDGElDIrKg79sEepgtzkpP3e3wgU+i0m9J5PjVIbVjIUK X-Received: by 2002:a17:90b:390f:b0:381:939e:adf0 with SMTP id 98e67ed59e1d1-38dc7752a8dmr13926711a91.31.1784086673448; Tue, 14 Jul 2026 20:37:53 -0700 (PDT) X-Received: by 2002:a17:90b:390f:b0:381:939e:adf0 with SMTP id 98e67ed59e1d1-38dc7752a8dmr13926691a91.31.1784086673026; Tue, 14 Jul 2026 20:37:53 -0700 (PDT) Received: from hu-petche-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-313b0240570sm53899311eec.28.2026.07.14.20.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 20:37:52 -0700 (PDT) Date: Tue, 14 Jul 2026 20:37:50 -0700 From: Peter Chen To: Thinh Nguyen , Krzysztof Kozlowski , Dmitry Baryshkov Cc: Krishna Kurapati , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy Message-ID: References: <20260710-warping-resolute-wasp-e4b8ce@quoll> <7a099224-ea95-40ec-b279-f8834f261e23@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: 8CUxP-mHhWyfcNWn8xtngYD7qbIb5UwS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDAyOSBTYWx0ZWRfX1KuyHSf8nnP4 lN+MzWuqPxLpy3v01J3OGkbAygcnXZ3u38KhaeRlS5ezZVTkNn7wpTVa7z+BuJGqjlbGBlFWVVH lndaEBMh2qN7vC7P6gCTqCAmEvjPXPz7+rkshMceU21u7lbtj52YnC+D5wNKkkChitOl6yklma8 2dqhCoE+hAKmXAWVaVGiSMfLN/ruVAK2gzAD7AwfLja2dH6OPL+lz783LqAt+uuF5NPjv1/D1c3 0vfFjfnGe/SqD+KupZTbH+k3Y+pdGdWYXrFOPx0OunZ3U4tJpO2D7JPk3+sHA0vNiPWlB6AZVmE 3eAWQktL2WumSlZCmW8Nj5bOQvVpGykiJxt+yQe8Hg1GRz8QcMAHWhqmtegpGms7CbwrPuPT2OA 7b2Mb0mIueqzf0Ne2UBKrWRVDxroiFSz1wnSnpAURNo211G0iCJOeFQMl29or82XQme0s/pIcyu 7t2AHfFsSbhQaiMO7tg== X-Authority-Analysis: v=2.4 cv=NszhtcdJ c=1 sm=1 tr=0 ts=6a570092 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=1QtRUzTFQfe48BcbiroA:9 a=CjuIK1q_8ugA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: 8CUxP-mHhWyfcNWn8xtngYD7qbIb5UwS X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDAyOSBTYWx0ZWRfX2rQbn17t4CW+ y01JxtGVo1XzV2bvCtHnn41N2YFb702Tc2X+FSF6b/QEFuTd9RqZV4WaJWjzrpToLg+SQoa0ZLA wQol4GDQJ/vSS/x4r5d+R4IxQf7VcYc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_01,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150029 On 26-07-14 23:23:01, Thinh Nguyen wrote: > On Mon, Jul 13, 2026, Peter Chen wrote: > > > > Yes, eUSB2 is based on UTMI Parallel mode, but it has dedicated > > Physical Layer Supplement [1], eg at CH2.4, it lists eUSB2 PHY > > Features. > > > > > > > To go this route properly, we'd need to introduce a new phy type > > > attribute in the phy framework, which will be a bigger change that may > > > impact more than this driver. > > > > > > > It is not at generic PHY framework, it is just for USB PHY dedicated. > > > > I do not see big changes, it only needs to change above files and related > > dt-binding files, and other users may leverage it if the controller > > has special sequence or settings for eUSB2. > > > > The usbphy_modes describes the interface between the controller and the > phy. eusb2 still uses utmi, so adding eusb2 there is sematically > incorrect. If we introduce the eusb2 mode there, we'd have to audit dwc3 > and every other driver that uses usbphy_modes to handle the new mode > correctly. > > That said, I have no objection to adding a new phy type for eusb2. I > just want to note it is a bigger change relative to adding a boolean > property to the DT binding. > Hi Thinh, Only the new user for adding phy_type="eusb2" at dts needs to check the controller logic, and this is what the user needs to do that check the new added device tree property logic at the driver. So, it will not affect current user for phy_type, and I checked the dwc3 core, it does not need to change code for new phy type. Currently, it is only benefit for qcom platform, but eusb2 (uesb2v2 later) is the common USB2 mode, other users may leverage for this new phy type. Krzysztof and Dmitry, do you agree we use existed device tree property for this feature? -- Thanks, Peter Chen