From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5621A3CB918; Wed, 15 Jul 2026 08:36:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784104592; cv=none; b=WaGKZUPO67k0amF/pzjvZO32VdTx348lgMCkqQRq149xtU0lg4xaB3Nae4qkSFQvazheQxJe98vtgySz7bYAd/7SeblEmVLOAW6CBhKPsUWEIG5VmEFezBSeTVD1zJswBem/Qjxn+7IRUb8oz/TskgymyVkYk1mgU5gh/5soemg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784104592; c=relaxed/simple; bh=OXZt351X18XpFF4Kqe9OL3cHjVZSPvqUvDwCYU4v1Lo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KL2Iha7yWJNFwD+iDIdRQ2wKFoPC1hdmjGSfi9HRKeHCPNyghWfgUFD97+qclXKeBgHjrCOdID20HqOK4DPFglynOs9CqPeKSDbIfkLmosUbQFea7P9INEj5rkqf33YPexl8z6Rkb1B+Rd+gBqQPoVyMLZ0NTVeZwgsdWdkuHIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RkGFKicQ; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RkGFKicQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784104591; x=1815640591; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=OXZt351X18XpFF4Kqe9OL3cHjVZSPvqUvDwCYU4v1Lo=; b=RkGFKicQXKV2XmH8trACAOxvTR2Km+X9r1je976KK+uA4NkAi8T6zPY4 W6O5Gsqb1N4yhc2C0DBvTVDA0ipZ8E3c0O6Yxlw+6Qbs9GnBmqZam1C3t uqRQweEJJhMEsmV1VsdotmSoMXqGH+Rfb4EvWLtTvH6IGnorgJ0sjIcmX Gvuv2H8+rjDxl49Hn83Xyrli1LTNm3PzN0XquZsgWq6N9RSG/Io6Xdkef GGdy0uTRpghfi7aQXPOhGdbM34/v/tSpfbm7plbFNlZub2URiXqCYDQ2H iJtqLWs2f6bB79iKbZvyEsFpWIcfAGTGqHC/+YREPXyLsmIrxugOaAd35 w==; X-CSE-ConnectionGUID: 9/Wm8G85QfGtTl1oKe712A== X-CSE-MsgGUID: jO2lb2azRXGjiPWjGs3+Kg== X-IronPort-AV: E=McAfee;i="6800,10657,11847"; a="95879950" X-IronPort-AV: E=Sophos;i="6.25,165,1779174000"; d="scan'208";a="95879950" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 01:36:27 -0700 X-CSE-ConnectionGUID: 2hvGbn2YRe2kqd8lBpOmoA== X-CSE-MsgGUID: m0errHZCRpaO4EGo+/tjYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,165,1779174000"; d="scan'208";a="253495438" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.129]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 01:36:25 -0700 Date: Wed, 15 Jul 2026 11:36:22 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov Subject: Re: [PATCH] gpiolib: remove trailing comma from sentinel in GPIO_LOOKUP_SINGLE Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jul 15, 2026 at 08:11:06AM +0000, Bartosz Golaszewski wrote: > On Tue, 14 Jul 2026 10:41:39 +0200, Andy Shevchenko > said: > > On Mon, Jul 13, 2026 at 04:29:16PM -0700, Dmitry Torokhov wrote: > >> The GPIO_LOOKUP_SINGLE macro defines a lookup table with a single entry > > > > GPIO_LOOKUP_SINGLE() > > I fixed it when applying. Thanks! > >> followed by an empty sentinel entry. The sentinel entry has a trailing > >> comma which is unnecessary. Remove it. > > > > Reviewed-by: Andy Shevchenko > > I queued it but I do consider it a bit of a needless churn TBH. You should really be against Uwe's patches then! :-) -- With Best Regards, Andy Shevchenko