From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10FC73E8686; Wed, 15 Jul 2026 09:09:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784106590; cv=none; b=t13U/HsdDBOageu1+wpt9uTvLTqcazNdEV/yFhNlUJmcfgINpLAefoxgwSABM51lXsNvfmIIP9CjMPh81h2BjpjBMJ3tEpMaXPujS2lSqgew4oW3sdH4l+ueUGxzgz4rNMS9zGKbDVQNQw3o1N0QdcgbsnPh4IMFjaMcV9lOWhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784106590; c=relaxed/simple; bh=wdfNjOKA2HL5qdE3HJU90IgxCzHMRF70h3J97b2e7Kk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UULvyLXTGcIAPyRfByw4iSJa4LtUFixdnMSIcu4BbXQX+LMmT1cJ88tpjinF+gVJL/WM0mvSUx66bphte3xSUh87aeBJasuESxEO+jlEaee7DIrbFJcy/GqurMMtPtmYJe95EnOP7W4LH0+VNgUm/aKiEuwg2ofL6UwXQTGwkUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PMlijiOy; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PMlijiOy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784106589; x=1815642589; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wdfNjOKA2HL5qdE3HJU90IgxCzHMRF70h3J97b2e7Kk=; b=PMlijiOyey+5yrcF+5b6QISM42Zb9aHL/2kR84KJzjui1CMFqqfW2Vfm 0WN31N52eTgwtR4xYzbqyREPeQcEZEwcLAZFd8MpJzKYifDmlbd+8WDh1 Y14zPQ7hSE4TB+HQPO2z2TORRPLvlMOuSIAiG4R5Y8XUnd9e1AtOongRd Lj8fHCPkVpDljW5r83rpcvtp7sGfrIE2xmT9B8VgJRWvA26+kEMiyZ3af 4xefrzFxM3XsAS8eGKg3ueXhLTZeNoMiNtG3Xl+M17QMQ4FT5HNAi0Rje X1JMY5Aa1/kxEyMQhN3upUo3HDwdEWAq0KERXdD5LZs/f0lAUdLSS9O23 Q==; X-CSE-ConnectionGUID: 5YZl5btXTxKcEkhR3MOJ7w== X-CSE-MsgGUID: ezOET7NcT4KYfv0WmuyB+g== X-IronPort-AV: E=McAfee;i="6800,10657,11847"; a="84780212" X-IronPort-AV: E=Sophos;i="6.25,165,1779174000"; d="scan'208";a="84780212" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 02:09:49 -0700 X-CSE-ConnectionGUID: i3W0x0G/Smq35N+Ws3A/xA== X-CSE-MsgGUID: X9YpvOfSSd+K6YQ6IcmCDQ== X-ExtLoop1: 1 Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.129]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2026 02:09:45 -0700 Date: Wed, 15 Jul 2026 12:09:43 +0300 From: Andy Shevchenko To: Joshua Crofts Cc: Esben Haabendal , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Martin Kepplinger , Sean Nyekjaer , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Martin Kepplinger , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] iio: accel: mma8452: Allow open drain interrupt pin configuration Message-ID: References: <20260715-mma8452-open-drain-v1-0-b1dd2a440c60@geanix.com> <20260715-mma8452-open-drain-v1-2-b1dd2a440c60@geanix.com> <20260715104542.0000433d@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260715104542.0000433d@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Wed, Jul 15, 2026 at 10:45:42AM +0200, Joshua Crofts wrote: > On Wed, 15 Jul 2026 10:07:39 +0200 > Esben Haabendal wrote: ... > > @@ -108,6 +110,7 @@ struct mma8452_data { > > struct iio_mount_matrix orientation; > > u8 ctrl_reg1; > > u8 data_cfg; > > + bool open_drain; > > Hmm, i checked pahole and it says there is a 1 byte hole, maybe try some more > reordering to pack it? Taking into account that the usual frames are 4 bytes and that there were already 2 1-byte members, the place is good enough. > > const struct mma_chip_info *chip_info; > > int sleep_val; > > struct regulator *vdd_reg; -- With Best Regards, Andy Shevchenko