From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD792DF136
	for <linux-kernel@vger.kernel.org>; Wed, 15 Jul 2026 22:49:48 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1784155790; cv=none; b=pTT7xPgpSxm/tJZKkfQcFnaovLwANdtfRugPUoj7kUQRWWNzGJn5mSaiWXTrgyosSbkv9iS1bSCgAS0deMp6IxlyVxdAfttjZulaiOiVA1TiY9IL/0o/oGNOwTFHaSY9KmldL+p6rA80Ns4Y0+LMChyMmrRm3fO2GFkAeAgG3qo=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1784155790; c=relaxed/simple;
	bh=oN5ZyvoaMeXK6DSsBgYBlXg9M529R+zaKwO+ciO+PYU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=XYMCISP3MG58HVK0SRnbmUIGX1KcE558gxLBq89oZ3PMmovOk/Oaq4YII8vuDzOTDh9PMiEJP8csJmwncp3ygT9pQBGR4/A7JrmQe95E0hyNsirm3GVFAloLxmVdMCMp4Y66qXnt46ldv1AJhpayh0Zx1Ok3Xg3KRnLsVMcl6xs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BuVEeTEt; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BuVEeTEt"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 952DE1F000E9;
	Wed, 15 Jul 2026 22:49:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1784155788;
	bh=SY+YyJkbi1gEkE//gLhZ4wGARXCzfj2FI0PbhlEsEJs=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=BuVEeTEtLaeSeLb35b/P4K6lwhUWXQ8GqdHwbbMRKRAbLOg4+MsvbP5Gzytpd/mU7
	 XVQp8hnoo5E5uE3rNJnstfjDje1OHY3fEWSU893kgN79h0mnFG4fxsQJ9F7+kPUFLG
	 qQL9toveNQP5BwLb2Ub9htUTUbVsTq0Umypp96QZqktjYsQgH4biq905Mz/zCM5hhQ
	 K3Ui+qZTOowcgvtBl3KJe0U0INcBIyyQMprc+m1mxldzIFve4GF4pmDeTTRmFPLIWf
	 9VnU2aRfQDlC7QHgYx5WegqqamGoUc4AaeRZUYbu1WInySpJhIar2s1fUODCV9fqfm
	 hocLB4kJoS31g==
Date: Wed, 15 Jul 2026 16:49:47 -0600
From: Keith Busch <kbusch@kernel.org>
To: guzebing <guzebing1612@gmail.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Guzebing <guzebing@bytedance.com>
Subject: Re: [PATCH v3] nvme: reduce firmware activation poll interval
Message-ID: <algOi6OByZV9an8p@kbusch-mbp>
References: <20260715114401.1084214-1-guzebing1612@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260715114401.1084214-1-guzebing1612@gmail.com>

On Wed, Jul 15, 2026 at 07:44:01PM +0800, guzebing wrote:
> ---
> Changes in v3:
> - Add a common polling delay helper for nvme_fw_act_work() and
>   nvme_wait_ready().

I guess I was expecting the common helper to be the CSTS check and sleep
loop rather than just the sleep. I know the fw_act loop also checks the
ctrl_config in addition to CSTS, but that's fine to put in a common
function too.