From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15559223DCE for ; Thu, 16 Jul 2026 06:31:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784183509; cv=none; b=YEvEeSvfqBkasUUH2WpgLji+hvN1cS8S6Dw+pJ1z0D7tzqq8NeKnV0FQD9jYFpAEFPoEA8YHYfHX3ZnLvHQBD2nzdEfk+Npy0CfDb30/hkIYUyF0RMuGPpFCtuekMmddqf/gKFvWs5IvFdkTx5QJQCBAfRYeIY+9YW31GI3lGwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784183509; c=relaxed/simple; bh=r57/bGA5SSeMINPpQHLlRxJkyoKb3Z0IBSwnao6DBJc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IQVjgVhn2uux9OeYmnMH9/tMdz38WmAgO+bVQBYyqc0oyW3GppHeMQdA8qdgdKPt1OyebMG370o9H83DjzcBEO1Jmt+ekvHc+TU58HpkKehdUHfsLwSShNvsDiD0gpWRgx6QCOA6vqXVD5GPg1lE808nSw7NE1BdQ7DScKTS1NM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jak514vJ; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jak514vJ" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-48d6c621a67so2921644b6e.3 for ; Wed, 15 Jul 2026 23:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784183506; x=1784788306; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=OiVd73y8oqqWO8DT1671vLKitLMYW0Is544oA2VqVVs=; b=Jak514vJCPjhOTZomOKGymucdOrkOBzECDgkbFfIgE5qf1ZcXD2UcJ2dM3L6psC1jr h2kwPk8cFNfVLZJ+sK2L6TbOwBtmwWJQd59s8+NB5wXvdHGi+Kve6qEDrWJLiQEBA2S6 zkUV7iBJT4lFjvXb4nyINqHzLe104EbhabPudDHJP2uPGj5oyySiLPP3k2hK30ESSM+P z9b+07u8lcBEECVTlZLqA5zZiCkghfvd+ftJn/CwHXB4kjkxTbMDWy7lbI1k+Tb7iI5L jJeZsjXzB+dB3SwBQgKD8ev33YOJwwRPAe50pK8GvcHyEaZvuw3yigAO8DSPXnULqImY RFtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784183506; x=1784788306; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OiVd73y8oqqWO8DT1671vLKitLMYW0Is544oA2VqVVs=; b=QihnQFeY/DLBXHkt4U7jvYCLDgq9+7H3JbcM5jMfh+f+b3qz8aCilxsjLtLEEJs7ba 8IvhjA6rj+9WpnognN5Mpbe8jGYfwvb+DlvO8fM0LAcMgJLbcC26OYfbxQIGrvCniZzl PQGceiEk1aLZ9K/aUqo6raVQYY0tDqss0Y/fU7XwFAhYDtKwdsT7zE6EKUeroXKcz/ME St7Nv8qqgOCgrdCUXeVvECKw5XzSPZBXzBT/OsPOrd3suogsEfYrnJjRA4QVN4iddEFT 0M7o9E2khUSVjf9zhf+iVRU9zuW3cQCYgVSAKury4s+nWh1QN8PxJ5k0tzvCx8BVUkSC br6w== X-Forwarded-Encrypted: i=1; AHgh+Rrx2k4j0ZMR95aV2DgxrUzU149iFLpVcfP65CXieWiHOKpb0bHd9kG2s9IqhQldfDeo6thFXuZ0LH60Vao=@vger.kernel.org X-Gm-Message-State: AOJu0YyX2ejoP2HYdvRmSScI7b+476bLR72N2xsm+OznFs9RohbZiHg8 VPwohbBQq7JeFNoZAnEg031y/pzoSO7BRO+sk8+8hAKFSMy8kasfdD5B X-Gm-Gg: AfdE7cm8Pi7cRV74Z6yqNGgnq28pgyUqGPvvVNqcXsBvgGikxeNsQ84Rqq/ALYel1nY pC+F65BhR6SyXTr6ETw8o1rXXUqUyQ40z/OhWtCMwOKM9YEcSnsSBnmqVCBHfHmlFwKXvZWgttd 6OpOsFlTeNJRElxNG8dvqUrIKwj4sFJTsamq0M0jWrkjeKzdeCfq8dpOmx8X6VbGYkjctksbGDf NPpTQ8wKj7muwVbyddJ7QcwXUu9ve9V9IofUqs8zhPFzZKjToInG5foKVOrkWVCs2IxMbiM16Jw iZJZVE6e6fPEFdR0DKHhdP5RbMqVI7Viu2rFCUG20SNcY8In+Wmx9eR+cuBvCP1Xw4cvuXcHCn3 LeIxArfdzdhyRQrOrzBjii576D9DoiC9kDmB3/Xp9UTarUB5TzwkcdZw1gs8v0+fu7dMpiT23Wv NjPO9PWqhT3uSOUwI= X-Received: by 2002:a05:6808:4fc9:b0:4a3:2bd1:5220 with SMTP id 5614622812f47-4a47a7320b0mr6927850b6e.36.1784183505842; Wed, 15 Jul 2026 23:31:45 -0700 (PDT) Received: from localhost ([74.80.182.90]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4a1afbfbbaasm17501698b6e.12.2026.07.15.23.31.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 23:31:44 -0700 (PDT) Date: Thu, 16 Jul 2026 09:31:37 +0300 From: Dan Carpenter To: Amin Madani Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: Split multiple assignments in _rtw_open_pktfile Message-ID: References: <20260715170003.94569-1-aminmadani112@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260715170003.94569-1-aminmadani112@gmail.com> On Wed, Jul 15, 2026 at 08:30:03PM +0330, Amin Madani wrote: > In _rtw_open_pktfile(), multiple variables are assigned on the same > line. According to the Linux kernel coding style, multiple assignments > on a single line should be avoided. Split them into separate lines to > improve readability. > > Signed-off-by: Amin Madani > --- > drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > index 4260ed5f4..598d94f1c 100644 > --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c > @@ -15,8 +15,10 @@ uint rtw_remainder_len(struct pkt_file *pfile) > void _rtw_open_pktfile(struct sk_buff *pktptr, struct pkt_file *pfile) > { > pfile->pkt = pktptr; > - pfile->cur_addr = pfile->buf_start = pktptr->data; > - pfile->pkt_len = pfile->buf_len = pktptr->len; > + pfile->buf_start = pktptr->data; > + pfile->cur_addr = pfile->buf_start; > + pfile->buf_len = pktptr->len; > + pfile->pkt_len = pfile->buf_len; https://lore.kernel.org/all/aZ_0OratIkUBNHmy@stanley.mountain/ regards, dan carpenter