From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFEEF2D8399 for ; Thu, 16 Jul 2026 02:36:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784169363; cv=none; b=TzaXjjYU1quPQNVEpa2es1LBKATGcao5IAb9T+EIETdbtdOO7hlgqy/ZFNTIYOnMLEYf9lCuMMZ+tseCYfsYaIWajMMaDT2AWOw8sGN9sciGiqFD1NbkQW7Posj/nY34FZylvIn8jbJGpTTOg528IIwg4nFiSEAlI2cRaJsJ9hs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784169363; c=relaxed/simple; bh=h1UZyikz0JDoM1JObJv4IyOGznkDwWbgrD2GEUT7r14=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fI0wLnGTPTAf4Oe553eK1poDhrvVUMdTofG7pvdfIfS1qrKH/+WFqVH8WOyFO+CQcyDaJmT5YGFSz62qmxwxOV1wBM8x6KxZXlXBbKSqlqbd9BX1OlHjBsK4djtHM3mhnyB+0NseFM2jV8z8XFImqEHvuzd3OAPgQ4Kq5+XLVHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eIyNH0o/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=E/+j91MH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eIyNH0o/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="E/+j91MH" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66G0q7q81253061 for ; Thu, 16 Jul 2026 02:36:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=g05Nqs0a+DO3y0LDbu2S/rRe I308lTNH3/Hk03QO/Pg=; b=eIyNH0o/a4myHg3bP/nbm19i2mgZUwFhTPhCQT1m 8kuhmlCX763vDqt1xE2rLsIvrSOPE6fRWv4JlFn8xVzfLWhqmxgSKqkgqEgPm9FC zMdaKjVkn2g+H0JLV5XKj5PjybgqcqMlt2FuTCD2Lv+eBE9CWtHFkAuD2KEMmNHg eFWFfynIZ5UKG8+XZvfima8ViXnnPdmlw4X7rnoWMxl7zFEkO3+BQx6lZLeIMaMQ Z935+HUeTVTNPxg9ZIM0CkBxZQz0lIgyOAPtmmZO6Q5Iehj5TQnS7JYhqqn5yOY9 nx6MQ7XhXBFjzlcEZZB8RXSlaOGWYo/4bSw/mzu+ZQ/UOg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fen4w89jf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 02:36:00 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c8894570b58so2168876a12.3 for ; Wed, 15 Jul 2026 19:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784169360; x=1784774160; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=g05Nqs0a+DO3y0LDbu2S/rReI308lTNH3/Hk03QO/Pg=; b=E/+j91MHD5jp6lDdmbMlXaryyDFubCYuCRArzTvPzqVbjz46s++JDPfTyMO9QemfTi jmz8txmTKC4+oGvzFw1KvkauZrsDihDiAmZzyNDtqJzy9RURS+4KZmZCTZixdT/ce05D tjWfc64+4vCGRJ69/48onC6HG6qt+DkDN26XjEqrDsivZeHaCTi36pEUhrsice9a8ZmU 3qMo0yneREfA0GVkaXryXLE5kLdYZgOAYwliZZfiAkmokvQfiicIvZTVAGX4kKelXpW6 2K/vdVOi6V0WcaS6+NvzkbNvJQUMBq8/3AMYDSVzmPghj3o12WEgEXrFvKLEAzt8GdJ/ G9xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784169360; x=1784774160; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=g05Nqs0a+DO3y0LDbu2S/rReI308lTNH3/Hk03QO/Pg=; b=lGXjhkjsZ2gWPbjc2hLA5d8GIUMLfnIXsIzeEQhl5mh8/AuLxXRpTv9rBno+2Nr9kR hYfzAGQEyEw40NRV5qoaXEJUOzSLqjxGv4BKhAlDjEsyeJ9WXTh6tYwt39c2RHBnlG3C YMhehDkFJWj6xEAg59GhsLqUzv6XFvUVDU6zqR89OOYFR13Xehd+6D/z4YHTWSg3kOic LzKPJ3xLaJhg4Cl/Fu8M5UChWocwjaMCYfIxF8J34LIqPcoOXZKOX+N4NNmNWrtaxQpB SEqBsGiU5/WSWEAN0whRugX10k5+pNEpqsWnwLDmC7iX9ZpWYp/MB7A/kIZKRjFEfxY5 WLkQ== X-Forwarded-Encrypted: i=1; AHgh+RqGem7f0zPFpW8rg+ouaOGQQQT8ag93w4XNjkOAkSQpykax9lmci+tu1UclGc8VIpqhIm8TfB+60zSN6m0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy683oJQZ7HKezUdkw8lhk6b2Yn7jLDUFKka2spyeBoW6r4xGDM H97MpnxsUDfmGSP5BRnW1qGoQFIz272wwYoQjQ1vp8rpVfi7NiHQCa7ZRWGwcSUxn2dQnaOJgD8 V/6FItAvc2EqZDlFMu/pS2Ut54IR3ULNtcg17Svbi/lY2L8qI1z7u6vyoTfCUo9obJoHlax2YFv SYNQ== X-Gm-Gg: AfdE7cnx9M2S6YYrTerBbQrTUXPJZB1MCNt/reeY8BpB/tyCYC4pWMQr/eaPKC96/FL uH3+t9xUm0s+pBCImSXkv/16rCEQLjMeq9AScjJzfvfnX/aVXgaAkUj8ohtGZjY7nobllfiqxMm IXN/OIBaSzINxz/HcLxAAr7YIClPnyEJKwftwY5F80vJhkE/lbBNLBOvvqZPnu1n0fDTBC2tCRU 5QqbRT+BHEwD7BE1x9lxGL1hOw4WLYdeEGU1uAZL4jCAWkHfHGiEXzbGaXAfW9dFJhnUB/5cN7E l1Wd/A0HTydWnObGJd7kWenVI8We24v6QFCdmYjOBmMleJx6lFKf9yKVXY/X8GZE/Vbbhf2FNqA ucHOjwDK2BwbjE/h0iW/MgMSud2npb6DNBVGdgLZdyFvx6RlPqQ== X-Received: by 2002:a05:6a21:4cca:b0:3b4:8a40:85ed with SMTP id adf61e73a8af0-3c11077686bmr20992750637.7.1784169360273; Wed, 15 Jul 2026 19:36:00 -0700 (PDT) X-Received: by 2002:a05:6a21:4cca:b0:3b4:8a40:85ed with SMTP id adf61e73a8af0-3c11077686bmr20992729637.7.1784169359836; Wed, 15 Jul 2026 19:35:59 -0700 (PDT) Received: from hu-petche-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13cd42a155bsm5829661c88.7.2026.07.15.19.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 19:35:59 -0700 (PDT) Date: Wed, 15 Jul 2026 19:35:57 -0700 From: Peter Chen To: Thinh Nguyen Cc: Krzysztof Kozlowski , Dmitry Baryshkov , Krishna Kurapati , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , "linux-arm-msm@vger.kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy Message-ID: References: <20260710-warping-resolute-wasp-e4b8ce@quoll> <7a099224-ea95-40ec-b279-f8834f261e23@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=PsejqQM3 c=1 sm=1 tr=0 ts=6a584391 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=ozYoIpVpmoLeJXfkQ_kA:9 a=CjuIK1q_8ugA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: kCm5T0-vxA2jdiF1SispQuRrwdFhlcKr X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDAyMyBTYWx0ZWRfX0RBnkxLnlNkM XRVmsp/UlS/K08KuChUgC0n5FrJdaSItOLRqh1d4yCwdsmdD4YNpWUY1lsHf/vGnjmaF52AyDFS AFqv/GKNzG5Gt9TnCBv8MH7/JQMdaBk= X-Proofpoint-ORIG-GUID: kCm5T0-vxA2jdiF1SispQuRrwdFhlcKr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDAyMyBTYWx0ZWRfX9OadpT/DtDN0 A5cVAn4toG6B09fpWzBHVVQzQGvXmoyiqhsQ+ZqHr2lxamwofUCzjIdAyeUCwaHQfK8hqrvu13Y OyaYOGBAOa9ocCUkiRE4akBV0dVa+eYUfYrGIMccpl9uq9orLtpKhdgNSkyCRi/CL7kA6msFdEQ m9KAVm5jpNNcPd3uoxl/P/omDUpu2CcmGC1R5kDwhb8JOsYrpTpZbXOMLSnBgzyIxgELDxxHUTR x5pktDd2TlcC1U63NDYE5Gm5v/zTxKkj1EgjNVAsE+uFFe1v4jcAM4C8oW1MJLE3RYf6bKVoPAq 6OUivey59MZCjpZ9wsfOfUM6hVlQvKyxdYZvT3qdKg8iiu98N+zUMz2/oFhSbeothq1Xd/LGF/j R4uR7gqYHN+18n+SIH9AtEZErpUINZiELaDhRQbtYi6jR7j/t64P8P16wJCWTLVxLJciTM4q13t chLeOIOuOKJ6fX8uSLg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_01,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160023 On 26-07-16 00:09:47, Thinh Nguyen wrote: > > > > Only the new user for adding phy_type="eusb2" at dts needs to check the > > controller logic, and this is what the user needs to do that check the > > new added device tree property logic at the driver. > > To clarify, are you suggesting to introduce a new phy_type property to > indicate phy type? If so, that sounds similar to qcom,has-eusb2-phy but > more generic. Also, where do you plan to define it (dwc3 or phy node)? > No, I meant just adding new entry at below usbphy_modes array, that's the easier way. At the current code at of.c, it indeed mixes description of the phy interface (between controller and phy) and phy type, the array names phy interface, and dt property names "phy_type". diff --git a/drivers/usb/phy/of.c b/drivers/usb/phy/of.c index 1ab134f45d67..5cbf17d493ad 100644 --- a/drivers/usb/phy/of.c +++ b/drivers/usb/phy/of.c @@ -16,6 +16,7 @@ static const char *const usbphy_modes[] = { [USBPHY_INTERFACE_MODE_ULPI] = "ulpi", [USBPHY_INTERFACE_MODE_SERIAL] = "serial", [USBPHY_INTERFACE_MODE_HSIC] = "hsic", + [USBPHY_INTERFACE_MODE_EUSB2] = "eusb2", }; line34: err = of_property_read_string(np, "phy_type", &phy_type); In fact, HSIC is not the interface between controller and PHY, it is after UTMI(+) or ULPI, and similar with eUSB2. The API of_usb_get_phy_mode is mainly used by controller driver to know what kinds of PHY it is connected, and do corresponding configuration, the configuration may not limit to interface between controller and PHY. Do you agree we just take "phy mode" and "phy type" are same thing, and delete "INTERFACE" in this file and add "eusb2" as a new "phy_type"? > > If you mean defining a new PHY_TYPE_EUSB2 constant in > include/dt-bindings/phy/phy.h, the glue driver needs to parse the > phandle args, and the eusb2 bindings would also need to change the > number of #phy-cells. That's a bigger change. > No. Like you said, it is a bigger change. -- Thanks, Peter Chen