From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 684A5266581 for ; Thu, 16 Jul 2026 06:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784185054; cv=none; b=E/9LZZQZ4sTsFB8NxDkqkTmz7U7LO8k8G1odBwlHlkvHMnZzEwbQHAQBcDlJASgZoisVo2ta7NhzPsi43ijj0cURCYCIUEqnxCKlss+Tr7g/OU5q4FLoG1Kn4QFMeVu9x9qf5GBe2lxU5ThphYq5xPUYVW5tYEPcEp7zUs9/f0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784185054; c=relaxed/simple; bh=xLil7Vstv8VY9VX7lK3ig+izqWkJrIls3b9UTEkEz6g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HTy9t7b7lEVF9l0KhxB73tKy3MT/lg2pSD09LG0JmS5cF8k1magfj7E5UwMnc5hNWgfVc36BOfLBkbbka8LLQGonavlf6uT7bVeUDox0CTuNeBA7GM5mmgKUuqM/pLH+vJXMDbVUNgfEm/gHmhCzmeU2IPYUUgDwCX+30FZiSlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EY62NLIf; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EY62NLIf" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-44cf70de986so2108001fac.0 for ; Wed, 15 Jul 2026 23:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784185052; x=1784789852; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=JQwzC+SeknlTO8OOS+hCXasYqtaWNkX7Yw3a3+TJWPU=; b=EY62NLIfBznC09stdXTxujzdKFbtzh26E4CDLhWZV6mm3+qo1pWH613W0SqQiASh7v rEe9aGuGXlhOSEL+G/2DJ2CA4nD3xGRRTuBRGroSPDUjSMI649zUOUQQ8TbOiHD6gmpy 22rckdMZ4SKhJ2q/WciopsiBujh2vX2OpOa11XIXYDk13XIwkQbbDNvo9r0gxlqWSSiM yxJ+G0qz6sZKfxOhSXO+zHBsqmZ+pgHXhHonCWAC8sLwUCSfA/fRvxBO81po02FvV6GY yzTKec2LgADDvDhEEffe0j6SePmLwP5lQbOi5u0tkr+7fAgN9Rva0CO+GimSz5PcBPEU Lkjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784185052; x=1784789852; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=JQwzC+SeknlTO8OOS+hCXasYqtaWNkX7Yw3a3+TJWPU=; b=mOdWwX9muUjwbj7dExDzlUnBSpnbZUC/oa9YpJj/b1xEgSSvK9tokM0SRfyJv2zBLa S86Tn0e0UC3wla/9xbQXBochQ++RVVB1akUcB37wwlu9MJWVQ4Uqz2RPhuj6fjIPJukz Qun69g6o4zBY6GxIgxLBHzTOMk7IdPKO9IFTFP9MRpRGUGSTEHXlk7oK9X9wJv3elcIN /8My3KnLAxzSKHOZcXqIsfXfn+DdniXg4DFi1L7ZDeGe7K9UiviX64/UMPENzUoX/ddy iKgw2bi4PhPWF3M3ISuGx8FbvMPUeiMEN7bN2Jj0YDEoMBCAmMPdWF2sev+lb4TceTXg wroQ== X-Forwarded-Encrypted: i=1; AHgh+RpZ+fRvLDknzJzpicIkomZLrceEK8/8PAyvSPy/u9TKkysen0juVd6n+0dNFFUoyKFj8fBUrVDMocyf/gw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyjdkd4eCviCHAsMqx0Z73uvklhcvMx0ImdtCXS6ZIlaJ2slY6+ DzoxG7xch+ESYoa+cnH1EmQUjZyaH/IIDG5WTRZtaA9zxrXa5fcOLX0/ X-Gm-Gg: AfdE7cnRjAO9GC5WAE7jjANKFT4tny2T2jtxcBnQBMBp+JDq3JnCm/Kbd7uh/qq+RSO GfEYDaWObV2WB1JTSRHaYz4d3yYllLgRakYtr+lmWMX+jCpslXkGTpP195xsirZLs70o7KuOtOi xpIrEqrnLF3Xq/7pRgUN/qp5M5f67j82FF+BxxRWjB6TBd31zTx15pbJd2hMVRCo0+dRPU9OHhb AkXgQo2yoQBVrkKbDCIMNQoM5B7mwpWysHE4VBFq+zv9fR9q51yCpTuaOF1d2hewNbtLUubft2P uh8uHOYbFpWEoReQXYJvnN4WItp+OnT+Y3b9KVzOJmjFQU6B0O75/F/EsL6KyWX7XO6aoZVongA 8meZnt+dShmwjWEYkGqz8b6vqMk2WHFDveq5bYkTId6HBuj5gqcLMhTN8H4O5gGudqNg0cw== X-Received: by 2002:a05:6870:4596:b0:448:9e35:c3fe with SMTP id 586e51a60fabf-4562b5fa188mr3879300fac.11.1784185052273; Wed, 15 Jul 2026 23:57:32 -0700 (PDT) Received: from localhost ([74.80.182.90]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-45191643abdsm21502202fac.11.2026.07.15.23.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 23:57:30 -0700 (PDT) Date: Thu, 16 Jul 2026 09:57:24 +0300 From: Dan Carpenter To: Markus Elfring Cc: netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , MD Danish Anwar , Michael Grzeschik , Paolo Abeni , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Vadim Fedorenko , Yibo Dong , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] net: rnpgbe: Pass an expression directly in rnpgbe_rm_adapter() Message-ID: References: <7958e26e-a4f9-48ee-8d79-3797016944c5@web.de> <8110bb3f-70d9-4f0f-82f2-ffe1262b2962@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8110bb3f-70d9-4f0f-82f2-ffe1262b2962@web.de> On Mon, Jul 13, 2026 at 10:22:06AM +0200, Markus Elfring wrote: > >> The address of a data structure member was determined before > >> a corresponding null pointer check in the implementation of > >> the function “rnpgbe_rm_adapter”. > >> > >> Thus avoid the risk for undefined behaviour by omitting the variable “hw”. > >> Pass the required address directly to a function call. > >> > >> This issue was detected by using the Coccinelle software. > >> > >> Fixes: 2ee95ec17e97c58b65e978a08b75fa8cb6424e4e ("net: rnpgbe: Add register_netdev") > > > > There is no NULL dereference here. It's just pointer math. > > No need for a Fixes tag. > > How does your view fit to information in an article like “Fun with NULL pointers, part 1”(by Jonathan Corbet from 2009-07-20)? > https://lwn.net/Articles/342330/ > Of course you can't have NULL pointer dereferences but this is not a dereference, it's just pointer math. regards, dan carpenter