From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0763BCD24 for ; Thu, 16 Jul 2026 13:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209919; cv=none; b=LIME7tsIgpyzCCKN46A0TE35Bb0yiKUSHYxLAm8YV34Q8IMnp8msZXz61bHxIBId/Jaz1pKGHmptMggK0Q0lq7d51xWWc7leoOBz46l3qRFLeGAaW9ZLaTdJFH6B/gfZjFOw/msEpf2H76UDjIc/CRw/97jExkcnavb2WC0o3hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784209919; c=relaxed/simple; bh=XtzsztxeppBQxH/Akd4jm73cdNX+VzFx8iXxL0SIdbw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CcyTDw0FHz4YiYY95XbV9wvWyH0c1rGHbMF1IVmY3AfHLXwSzXD1+Gu+QqS+SgaSYYVOKo2+RJSys0c+IKHSYSYwq7UuENLEGI5OSx4hCm9EW1cB/D94oNbPQ55/tY9UJYyhM8iykwMinNl/USjc/h6y13mhwSC4m7dcivHCjBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JNCDiMmr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JNCDiMmr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 012261F00A3A; Thu, 16 Jul 2026 13:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784209918; bh=upS5dAIhqaeNkD4Y215zZ+qqauX1huW7BJD20LHOgmI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=JNCDiMmr1ueHBLvBy3MYHFTMFeo5yJ5AzXu+ouiki7cfoMixmPoMHunzb4dN7S78z 1oBhDZccLk3T5PHQPKeXKzqdckE5Ej5kM0VTCEFf549WMrBwUa+nYLFjFcrSk5cdXe kFA+SBK3rFwjNo9nlxFvi3shGjhb7bAHW2KlpBZ2lPnZeJiW8d+HRQWkiHCxxa7+xM JrH90vMWFUJ3hN3bPdiKp0CzQ3Ewy4YB9eharf0q7HgO0b6vTS/Y1gfn3Y1xaqRHag ux5ueYDs+oBJlDBaR3CoI8HTz0qsPmt0Z8cSBYwfiOuZs/aSvc3wcILdYV2DEgJUBN vVn4r3kSRM1mw== Date: Thu, 16 Jul 2026 14:51:43 +0100 From: "Lorenzo Stoakes (ARM)" To: Kiryl Shutsemau Cc: Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kiryl Shutsemau (Meta)" Subject: Re: [PATCH 1/2] mm/huge_memory: remove unused can_split_folio() Message-ID: References: <20260716100345.473473-1-kirill@shutemov.name> <20260716100345.473473-2-kirill@shutemov.name> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260716100345.473473-2-kirill@shutemov.name> On Thu, Jul 16, 2026 at 11:03:44AM +0100, Kiryl Shutsemau wrote: > From: "Kiryl Shutsemau (Meta)" > > can_split_folio() has no callers and no definition under > CONFIG_TRANSPARENT_HUGEPAGE; only the !THP stub remains, left behind by an > earlier cleanup. Remove it. > > No functional change. > > Signed-off-by: Kiryl Shutsemau (Meta) LGTM, so: Reviewed-by: Lorenzo Stoakes (ARM) > --- > include/linux/huge_mm.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index ad20f7f8c179..6961db4d1591 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -621,11 +621,6 @@ thp_get_unmapped_area_vmflags(struct file *filp, unsigned long addr, > return 0; > } > > -static inline bool > -can_split_folio(struct folio *folio, int caller_pins, int *pextra_pins) > -{ > - return false; > -} > static inline int > split_huge_page_to_list_to_order(struct page *page, struct list_head *list, > unsigned int new_order) > -- > 2.54.0 > Cheers, Lorenzo