From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 361703264E3 for ; Thu, 16 Jul 2026 20:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232689; cv=none; b=HsR7vX1GiwnDbgOdjg6zA6YfPqwTDpP2XcZSW+f41o2tWEr/wp8O9AmrOKNbtS4WH300j7qo0h6Q+/56H0XtivBWGqV3qRw6FuWyohB6o5DesXL5ltx8Y1to1UXZEJixQRLgMavquaNgO8WyLRc7LocOOUAuqJNmqZppbVXbmyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784232689; c=relaxed/simple; bh=Zbe+DLmNGGowdg+a4rkRli1ozSpKoRwDjJpp/j8LP9s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z+YjS17PKTWgVRUXtZew3HuP0BKsu4bHp1Tn5Y4/PkrIC0USNn2O0O43Y/6lDFZd6mkiM+CJtlZY877ZYbq8Rv4DNMEibzG2U27WJBibrNOG/AjRs0r7PQh74J5fZYl4d3fm5fTm0XLlFiexJLCNRSqg8InHTaAEpAZq7hEAQ8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=u7JOyMR/; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="u7JOyMR/" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D1DA1476; Thu, 16 Jul 2026 13:11:22 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 57E0C3F7D8; Thu, 16 Jul 2026 13:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784232686; bh=Zbe+DLmNGGowdg+a4rkRli1ozSpKoRwDjJpp/j8LP9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u7JOyMR/ZUz8n8sQkUznNOsd0jBtWTUuPIKo3tXm+21j3SnynJpsVD7SrMD5ZI8zv bBV9KSnIuAPGBF1sc6KoOFDJsCepW8v+ON7TWeVv4kPHnuZYEJO8R1zcCPndBDPS7B ZVTVtQXcLNZxfuyU53Hd+vRCXDvLz/YHh1YCINUM= Date: Thu, 16 Jul 2026 21:11:22 +0100 From: Yeoreum Yun To: Suzuki K Poulose Cc: Yeoreum Yun , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v8 00/13] fix several inconsistencies with sysfs configuration in etmX Message-ID: References: <20260629090007.1718746-1-yeoreum.yun@arm.com> <6ec5e456-fdf9-4953-9a0f-6231b48df07a@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > On Thu, Jul 16, 2026 at 01:48:15PM +0100, Suzuki K Poulose wrote: > > On 29/06/2026 09:59, Yeoreum Yun wrote: > > > The current ETMx configuration via sysfs can lead to the following > > > inconsistencies: > > > > > > - If a configuration is modified via sysfs while a perf session is > > > active, the running configuration may differ between before > > > a sched-out and after a subsequent sched-in. > > > > > > - If a perf session and sysfs session tries to enable concurrently, > > > configuration from configfs could be corrupted (etm4). > > > > > > - There is chance to corrupt drvdata->config if perf session tries > > > to enabled among handling cscfg_csdev_disable_active_config() > > > in etm4_disable_sysfs() (etm4). > > > > > > To resolve these inconsistencies, the configuration should be separated into: > > > > > > - active_config, which is applied configuration for the current session > > > - config, which stores the settings configured via sysfs. > > > > > > and apply configuration from configfs after taking a mode. > > > > > > Also, This patch set includes some small fixes: > > > - missing trace id release in etm4x. > > > - underflow issue for nrseqstate. > > > - wrong check in etm4x_sspcicrn_present(). > > > - missing call of cscfg_csdev_disable_active_config() > > > > > > This patch based on coresight tree's next > > > > > > Please could you move all the "Fixes" to the top of the series, that way > > it is cleaner to backport for the stable kernels > > Okay. but the fix which based on the cleanup wouldn't be top of it. > I'll deploy below patches first: > > coresight: etm3x: change drvdata->spinlock type to raw_spin_lock_t > coresight: etm4x: fix leaked trace id > coresight: etm4x: fix underflow for usage of (nrseqstate - 1) > coresight: etm4x: fix wrong check of etm4x_sspcicrn_present() Sorry. Ignore this please, I've moved all fix in the top properly. Thanks! [...] -- Sincerely, Yeoreum Yun