mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Jun Zeng <jun1.zeng@intel.com>
Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	andriy.shevchenko@intel.com, gang.cao@intel.com,
	jun.i.jin@intel.com, yong.hu@intel.com,
	Liang Fang <liang.a.fang@intel.com>
Subject: Re: [PATCH v1 1/1] nvme-pci: adaptive interrupt coalescing
Date: Thu, 16 Jul 2026 14:52:41 -0600	[thread overview]
Message-ID: <allEmTmXCFosxIOr@kbusch-mbp> (raw)
In-Reply-To: <20260715075703.15578-2-jun1.zeng@intel.com>

On Wed, Jul 15, 2026 at 03:57:03PM +0800, Jun Zeng wrote:
> Add adaptive interrupt coalescing to improve IOPS for high-throughput
> workloads. Monitor IO pressure periodically and enable/disable coalescing
> automatically based on IOPS, queue depth, and inflight IO thresholds.
> This feature is enabled by default, can be controlled through debugfs
> variable during runtime.

Can't you do all this from user space? You'd maybe need the blk-mq
debugfs to get access to the individual hctx dispatch numbers, but maybe
that's okay?

The atomic_long_inc where you placed it is especially harmful to polled
queues.

  reply	other threads:[~2026-07-16 20:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15  7:57 [PATCH v1 0/1] " Jun Zeng
2026-07-15  7:57 ` [PATCH v1 1/1] " Jun Zeng
2026-07-16 20:52   ` Keith Busch [this message]
2026-07-17  1:10     ` Zeng, Jun1
2026-07-17  8:06       ` Shevchenko, Andriy
2026-07-17 17:06 ` [PATCH v1 0/1] " Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=allEmTmXCFosxIOr@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=axboe@kernel.dk \
    --cc=gang.cao@intel.com \
    --cc=hch@lst.de \
    --cc=jun.i.jin@intel.com \
    --cc=jun1.zeng@intel.com \
    --cc=liang.a.fang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=yong.hu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox