From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8460F33B6CB for ; Fri, 17 Jul 2026 03:45:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784259908; cv=none; b=bEFj36WQnDWYimodvGqGjSkpvwQyEEnPKPajpmb+rdpM6+SeLSBhIwoNhufjwkqQAeGnuOQO+9ivVbaMUl6Bb+QHHwPf97dGhNv8EtyM/AG0uckP86alr0B3YoHB4Dqg0HC4J2KOb3he4v3Di/NHCm8inlSZ7fu/O4beVl1RVVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784259908; c=relaxed/simple; bh=lgeOh69LMqGbdV7nWGQFWSEx8qferoZaEx5dc/0EC/o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YoORwn6FQg+Wo3uaXkxJMeL+siTTM5M4UIuvLxpO8N1qhnFLGoacAhr3IGNgHLxIazDitozFm/L/ZTPVz9UEPywYcx7BnZ0prxpQeHMAAkTGUTYkAbYbhpkhSM5cmIRk6VwLG4pyDBDeRCoS4IK8j6YCCzASdVCZOvkWgwL/Pjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Lf2kAOj0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=foxrOsOS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Lf2kAOj0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="foxrOsOS" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66H33pmN1617217 for ; Fri, 17 Jul 2026 03:45:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=sh62sm/bV4T4YCCFfcyf7I8t tuUk1EXYq7Cw+4r57Ow=; b=Lf2kAOj0i7RBlT5MqNnechPUgpZUx48j+noktMJv U9jTwlz8ksejWGC/LWyRnyhM4Cm/CgS5ZImIKvrOiRvRZa+qeE4EdSmipUfi48Lf /iT1K79Mbikw0TDm66PGJGCZEa/0EjvRCRVTfC9MdZA+WACShLPdV4OoIPoc8SL/ 7TJSSWZerPHDpZV2w6IEhDdmKaDVG4yLJ4BHH4BFy+5vij+HLofAKyb2boD0xidj EU0U+JvR5VdRdGryNb8iyJHd+7Cy2cAZvK4sfECiSwKJJzX8ExcLh5Be92YKpSMX r5N+atMYt2Bckvpz68s52577dhJ3gXjEYRaJ/G9j9dx0sw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ff3u6hu1h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 03:45:06 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e1118e4abso6048770a91.0 for ; Thu, 16 Jul 2026 20:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784259906; x=1784864706; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=sh62sm/bV4T4YCCFfcyf7I8ttuUk1EXYq7Cw+4r57Ow=; b=foxrOsOSn1kMxsDlLJOl5mdqpaJ4hg90j4FoOSPm5BTHb8YVNNiIUnOkggtjoHP87x 7PrUI5W6+MDqL85GhwJhziPQizmtXjVTQDiC6x2kSZbsbKTKxyZ86tgPp6ME6atPf1nY X4cx7R3WJPifiGFjrhk/0P89YBz/ZJ72IgOy/sEC6mBXh5W6GztJPah905n4ELxet6dY koI8izBBdtywa5gVevLmhVdyKsgubH12Ldd8lHCg+N/OPCVWhwkZPmRqnDBuBeUGD0rX MHuiI6jJXQBwH2Bh/3IvXLkke8vt+99j7MW7oaDWX8TUJUHzHoPfBa3DaE47kHnkHtfz +V0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784259906; x=1784864706; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sh62sm/bV4T4YCCFfcyf7I8ttuUk1EXYq7Cw+4r57Ow=; b=A5Y/DrIyuILENJntbaobKxPXHRNtC+NUFFtOjeqpXzU05BYWjEzgqSDQ9QolXn974w xeJQbc9ApRbbVm3R4yqHuxmD7uS7LvyItdtAXRuQHZH2iWwZ6FM0oSpuCZG67/YsrYQu RefQhcutqoLlt28Go5X3ioA9jyxEgvGNEC3xHFQwrKA7s2+OtZIicxCP1oD6crhSIOrd z9ZhhllQe6iVWS6UCS0vuZtFRawsSUBt8w0Fevymx5pWM5ZtodnSmxmbFpSnnB+WqyeH P2c9udZFJGJD1G47vDjy7CCMgmGyCJIds4nlZMjxc4sK2ivYXULal9xBWJmGyZaus2w2 Pyfg== X-Forwarded-Encrypted: i=1; AHgh+RpyeJBrDqnDjTVwh/al0hKbPazFjeDvRq75FGv3Pc5qMdt4oJJs+aZRcafF0ewu3EjoCHHZUQE2N/1dWQE=@vger.kernel.org X-Gm-Message-State: AOJu0YyBYxhSMG398wnUJntvUEIwCm6FwosK/pvwu9fgbUvuBxg5kuZE ZlZfpswzAcciZkNJ3/OIWSSMs0TykEzVjqjjcHONxyPax+5O8b1oFdJr/gZKvK/FDMF21NvYX/L CDBpABCa5Ak13RZ6Kh5KhZxwzld+qpsu05LePtI5H3698Z7AFs9/acB2oMEkEKLGs/ug= X-Gm-Gg: AfdE7clWYWjhIhh9ZHR4GReTwmXBo+yNIjPO5jOehalIjnxdgZBlU5NoovfjgMuNlTz EQErhRJRRAPWV8wW2M5WbpxALwT4olR7NVVnybUhTmeHOrTN7+uUsqlY5F0JpiJw/nu42g4LXrS vljonWcFI/CV7Wx7l3NUcpixSWg2/LiSBdqaRg9uG4YbKe0Zb3Zw3kD2uPx8iclhTV8b77K3dN5 uUGt7/rUAMw2UaZ4EkPAQKKXBAUOW22Sk6tAw1ayxY75fe5/9hpPe8UCuU3TjFXkEEggQfk+w6T ytc5dLjnrduTEcjSMl+8lqB6o7Mc77IIcvUjwxzYYehPgLXru22SITWluU5Q0j0M61EgbLqIadV aJGf23YfhQvMMzfQhnGjVXr+sFHlgDa4QR/NUEojZWzQgXvk= X-Received: by 2002:a17:90b:4a43:b0:36b:bec8:94c5 with SMTP id 98e67ed59e1d1-38e4b44138fmr910028a91.10.1784259906054; Thu, 16 Jul 2026 20:45:06 -0700 (PDT) X-Received: by 2002:a17:90b:4a43:b0:36b:bec8:94c5 with SMTP id 98e67ed59e1d1-38e4b44138fmr909987a91.10.1784259905414; Thu, 16 Jul 2026 20:45:05 -0700 (PDT) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429fdcaefsm1779168eec.10.2026.07.16.20.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 20:45:04 -0700 (PDT) Date: Thu, 16 Jul 2026 20:45:02 -0700 From: Qiang Yu To: Taniya Das Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: qcom: gcc: Set FORCE_MEM_CORE_ON/FORCE_PERIPH_CORE_ON for PCIe pipe clocks Message-ID: References: <20260714-mem_on-v1-1-f5bfb6def0a1@oss.qualcomm.com> <81c314a0-c052-4843-96a6-80d8036fa6e0@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81c314a0-c052-4843-96a6-80d8036fa6e0@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDAzMiBTYWx0ZWRfX4xR9sWcaNE7Y 4Ygfl545VW5gLYZk+cacTZJsrcr0YtKqo1VUASJzKzEYmECdccHdqXc/sGoGRlkvTro96zDCszz iTPMTFJ59tvbk1mta8i6lWhgnwG3lPJxWSCrGjQepFo1ZXVMBDVQk9HadKtKkolOeWOWGTqK4W4 01Tpv0SrPEbYT5AoNtr0IXElUm/IR1T6p5c4aqJBH6iirjDyLekBkvrfB5F5wQchsEH+CIQdou3 BxAyhF1/Cdpf2e9U5aom0wAtMEQzUpIa42s0jperT9JKAuBAFDq2k8VQX9h5ZuzE95SegneEnjE xUnZ/ObTeJKGVfhgJSiHhuokwi/LCiiUwGmf2O+gKsnhrX8Qdsk2y01tzImUR/33IvYE5e90fzP ZvERjnpHHD7jUqZtQkkUxDORGQfy53ED9j8FuCwNJTah0iIV5bX3btTZEv/SKpcGJTvbr6uTFk+ MWVKws7im4E+Qqne/sw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDAzMiBTYWx0ZWRfX+OJlBWxVDIIY 4KWZ0LTy32HSqvbE7PrivWoIie+mNwbijyiDjL6X3wm1zNmL/Ijpzf7nIzEnDgzGMq/YANeE2Qq 7LG1qP5lKCOQ2TebqmPnFfVMIzRdQXM= X-Authority-Analysis: v=2.4 cv=DYMnbPtW c=1 sm=1 tr=0 ts=6a59a542 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=g8wsVXef2bgNkCobJpwA:9 a=CjuIK1q_8ugA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: dyxXdd3NyAOyvkb0BfzS8onkvhpX2iW- X-Proofpoint-ORIG-GUID: dyxXdd3NyAOyvkb0BfzS8onkvhpX2iW- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_01,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170032 On Thu, Jul 16, 2026 at 10:35:03AM +0530, Taniya Das wrote: > > > On 7/15/2026 11:53 AM, Qiang Yu wrote: > > Setting FORCE_MEM_CORE_ON and FORCE_PERIPH_CORE_ON for the PCIe PIPE > > clocks so that the inbound data path works correctly. > > > > Without this, the PCIe link can come up but the endpoint can not access > > host memory, with the host sometimes seeing a completion timeout > > reported by the EP, even though the host can still read the EP's config > > space. > > > > This issue is seen on QDU1000, Kaanapali, Glymur and Nord. Hence, apply > > FORCE_MEM_CORE_ON/FORCE_PERIPH_CORE_ON to all PCIe pipe clocks on these > > platforms. > > > > I do not see any such requirement in your code downstream, so trying to > understand a why both the memory and peripheral needs to be set? > In downstream kernel, we set them for kaanapali. I met similar issue when enabling PCIe3a x8 mode, after debugging, PCIe HW team recommends to set them. But to be honest, I don't understand how this two bits affect. > As I understand this was not concluded with design to understand the > reasoning behind this change. > I started a mail thread to discuss it. Can you please help invlove gcc design team to help us understand it? I'd be happy to have your team take over posting the follow-up patch, if you're willing - this is really your area of expertise. In this patch, I only added for nord kaanapli, glymur and QDU1000, but other platforms may also require them. - Qiang Yu