Re: [PATCH] parport: Consistently define pci_device_ids using named initializers

["Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

Hello,

On Wed, Jun 10, 2026 at 06:54:02PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> [adding Greg to Cc: as his tree seems to be the usual way into mainline
> for these drivers.]
> 
> Hello Sudip,
> 
> On Wed, Apr 29, 2026 at 06:14:53PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > ... and PCI device helpers.
> > 
> > The various struct pci_device_id arrays were initialized mostly by list
> > expressions. This isn't easily readable if you're not into PCI.
> > 
> > Use PCI_DEVICE* helper macros and named initializers which is more
> > explicit and thus easier to parse. Also skip explicit assignments of 0
> > (which the compiler then takes care of).
> > 
> > The secret plan is to make struct pci_device_id::driver_data an
> > anonymous union (similar to
> > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre.com/)
> > and that requires named initializers. But it's also a nice cleanup on
> > its own.
> > 
> > This change doesn't introduce changes to the compiled pci_device_id
> > arrays. Tested on x86 and arm64.
> > 
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> Gentil ping! I'd like to work on the actual change to pci_device_id and
> that requires this patch to be in.
> 
> Is it already too late for 7.2-rc1?

Now (i.e. 5 weeks later) it definitively is too late for it to make it
into v7.2-rc1.

What does it need that this patch is picked up?

There is also
https://lore.kernel.org/lkml/549d7f4d912e7c38bb93f0c40844fae291dac532.1781101238.git.u.kleine-koenig@baylibre.com/
in my list of open patches affecting parport.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]