From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 978DC3DD862 for ; Fri, 17 Jul 2026 11:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784286317; cv=none; b=XSWtAz9rdYdcWcJixtwZMFdOpYvWR3ud1uT7F22Ynbw8vMTmqdEJ45VEY0g54d5JI9EDtYR/5fC6DIaKh4R6acG2y3qtpFQXE97r+v5w3Nv2fIoVh49PBOnCY7TuRCQRusY02Q/wc/JVr7xNrXFVjfLnLtMDiblp1UaGx+TE5Fs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784286317; c=relaxed/simple; bh=vBET9pZZcoqpLF/r/h/pBh0ufFP6D+MZ34W2plt0c70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S3cYRmVDKqCGE/lgJhT6T7uoCZU4yW6AiwPvty+e/HzmE8VkgNSO+GpP1oYSlUy/b88KkOlibwx2r9V1vOGhDI87mih4D6tOyhjlmOAH0vHV1jy3ZTLAFWVggMOiNyn9/vX2Ews4uN1eaWxl3JU8bmNVgd6nwrUHcYcmgI0Y1XM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=fmD9qxEC; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="fmD9qxEC" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A35221477; Fri, 17 Jul 2026 04:05:04 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CF6E63F7B4; Fri, 17 Jul 2026 04:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784286308; bh=vBET9pZZcoqpLF/r/h/pBh0ufFP6D+MZ34W2plt0c70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fmD9qxECdRPm1OsXL/wfchgcVUmg9Qsp0z/PF8BGE3aHFscWP6Bf+R8Lt3KXelyDg pl3SzrrWHi4Fto63NpyXeDxQBTRjn5C2Zv7tlh8HGhqmPovgG1Wf1Xg0/JkcCLyY0I 6BMGfF7yzjYhMyHa48JCRUgVq4iccnUGPb67JWiE= Date: Fri, 17 Jul 2026 12:05:04 +0100 From: Mark Rutland To: Shrikanth Hegde Cc: linux-kernel@vger.kernel.org, "Christophe Leroy (CS GROUP)" , frederic@kernel.org, jstultz@google.com, juri.lelli@redhat.com, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, vincent.guittot@linaro.org, vschneid@redhat.com Subject: Re: [PATCH 4/5] sched: dynamic: Simplify irqentry_exit_cond_resched() Message-ID: References: <20260703133358.698078-1-mark.rutland@arm.com> <20260703133358.698078-5-mark.rutland@arm.com> <4905f97c-9154-4794-b337-808f6eec2949@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4905f97c-9154-4794-b337-808f6eec2949@linux.ibm.com> On Mon, Jul 06, 2026 at 10:12:29AM +0530, Shrikanth Hegde wrote: > +cc Christophe. > > On 7/3/26 7:03 PM, Mark Rutland wrote: > > PREEMPT_DYNAMIC is now limited to the FULL and LAZY preemption models. > > In either model, irqentry_exit_cond_resched() is always called and never > > disabled. > > > > Remove the unnecessary code for this when PREEMPT_DYNAMIC is selected. > > > > Signed-off-by: Mark Rutland > > Cc: Frederic Weisbecker > > Cc: Ingo Molnar > > Cc: John Stultz > > Cc: Juri Lelli > > Cc: Peter Zijlstra > > Cc: Thomas Gleixner > > Cc: Valentin Schneider > > Cc: Vincent Guittot > > --- > > arch/powerpc/include/asm/preempt.h | 7 ------- > > include/linux/irq-entry-common.h | 17 +---------------- > > kernel/entry/common.c | 17 ++--------------- > > kernel/sched/core.c | 7 ------- > > 4 files changed, 3 insertions(+), 45 deletions(-) > > > > diff --git a/arch/powerpc/include/asm/preempt.h b/arch/powerpc/include/asm/preempt.h > > index 000e2b9681f30..79fc1f9df88d9 100644 > > --- a/arch/powerpc/include/asm/preempt.h > > +++ b/arch/powerpc/include/asm/preempt.h > > @@ -4,13 +4,6 @@ > > #include > > -#if defined(CONFIG_PREEMPT_DYNAMIC) > > -#include > > -DECLARE_STATIC_KEY_TRUE(sk_dynamic_irqentry_exit_cond_resched); > > -#define need_irq_preemption() \ > > - (static_branch_unlikely(&sk_dynamic_irqentry_exit_cond_resched)) > > -#else > > #define need_irq_preemption() (IS_ENABLED(CONFIG_PREEMPTION)) > > -#endif > > JFYI, > Christophe had sent this patch, I am sure you guys will sort out the > conflicts. (I don't see it merged yet, but likely might) > > https://lore.kernel.org/all/2bf10a0afffefb6aca44bf2f864cc17471a80e31.1781870889.git.chleroy@kernel.org/ Thanks for the heads-up! Sorry, I'd skipped Ccing all the arch folk as I hadn't expected anyone was likely to be doing similar in the arch code right now. I'll make sure you're both Cc'd for any subsequent versions. It looks like the only difference for powerpc is that I leave need_irq_preemption() lying around. Christophe, if you're happy with this series, I could pick a patch from you to remove that (e.g. take your patch and apply it to the end of this series, reduced to removing need_irq_preemption()). Any preference? [...] > Change per se, looks good to me. > > Reviewed-by: Shrikanth Hegde Thanks! Mark.