From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F22D3E5A25 for ; Fri, 17 Jul 2026 11:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784289191; cv=none; b=N/J7qB/rXy6sTtjemlc4pDJFPeU6Kv2Tp2wOroyglTxOuDnROOLBnqHB3TNa469x3O+4e4g5nTDZT3ByAUZFsfddaMMv60I/N9HvEvbKMeboYV9bRjemQ/vseSW3UcMYomSm8Lib1MTII6Da08kTtxiRBhuCw95gslGFT1w9qkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784289191; c=relaxed/simple; bh=wXG5LQXJ07OroDz+CuOeRV0aSjihJMOZsDY7ckx3LY8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KydzDEXw728t/QTZMf3wywsPF7g82/l3nOUW6KwR6Fn/Jq1OhLGigO/nFo6x7xNhcgwh/fqw3i8Wtr0O9boGRJdc4/Kp+CsKTnDBGuy8aGnj81eLeoDm6EDvpqfEWAEwABBoNeW3qrNACTbWX41iIxRurT7MDrkjz67pPGgoxqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MeP61THJ; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MeP61THJ" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-6a3d77e72ffso1073442eaf.2 for ; Fri, 17 Jul 2026 04:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784289186; x=1784893986; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=8IQ4rZYCXmoKGNhUGfrKCmINcJDQqtVyHwlnRNnG6X4=; b=MeP61THJpcaXnEN+F8v6ccsCIwN4z/NnxHN4RoN12itgPjbmo02mze1ryPQcm5TnCo l2VwHpBl2kyBxspNRtnZC1UWmWOK30oYQjCuCA24+b3qdr7ZLhIQ7Ms0J6gzxYlMk2xJ f/5sWUqaT7XxbI/tUJkJCSHZ3Trk+8cikLOEMAsXU/+gCpswjj3X9mkbmUmjNZZfw7ya 6+OJ0oQTJstkqQ1i13u40sn3t4Q3a2/XXzncSSFGEGSvz9lMdcbrzHZryt9rZDShJNhg DswIMypaaz8uJR3cPHcea2os7G+QGiugMHWwm6agttreexXRJAbC6SJrWEArdCdYeMnP xyBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784289186; x=1784893986; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8IQ4rZYCXmoKGNhUGfrKCmINcJDQqtVyHwlnRNnG6X4=; b=ooRx/0Lz4qMKRa3HScUfmzdhd9aS2+KL+n3t28lzNf1akh1R4rf4RWq+8E29rtLl38 HvLbH4bxyA30MnXKMI8ZIBYE1FnQMI0NY4qaIOmtem2sGY7hg7w2rXFAf6N6k1e8LXIQ m/mBb0fH0tPtdNV1Lt7SgznXHOHA4H4tWGJPidKaLILovMO2IuSWdhZ4aaXuR4Xb2DH4 Es0XMcec48g50UaSxLzbvy72u3SDCsas8lHNIqfqk1kx/XSQjkE3E0ZekupjLOoDhzXJ JcQcx460aNf8lefMUrbBsm7Pi4vpMu6GT8mduSb1UQVnzyJUTWPKwOBmbjTIN6vtzCrU alzA== X-Forwarded-Encrypted: i=1; AHgh+RrM3jENySnqHi36Cegxuff/sJtybyyXN2E+L58Ezw050fEyVUC7bSkAaiEUI+GaK6FZ0zgRfLHczZ3jnnU=@vger.kernel.org X-Gm-Message-State: AOJu0YwngHNGQDr12gFRMjuR+lpXrXMe4yvqeAQZKh3SDJTFs9XNoWhU BQo0A6C4VmvnAbmJl/zmRpNniVygV0QweQ7i7fahu4ciakWl4zmTi2kR X-Gm-Gg: AfdE7ckbpu6+xmElAMYKz5PL+Vv7aR8R0zvwvDBWPXDFyOjOtF1eVWIBi+8bQIvcqIn tChJPSjjpoSqz3Qi6lfjjk19fBbOaXUTTbOdYZmthVpssJNperEvpTC5hv+g5m9MfO1/w+B1UNk tKERLQ723jAyRdwbDzfe1ACVNot+IPwUNb8sFb+bnW+S9HtH0arlISbafe2y2lsqumgjyUujOdd i6dOmCD1XqNtMXOdHQ7pfiWXgqlHJto9dBAbTT82dZB7989XlOJwW5wLQtZOZ8nSvZjyZOmYoAn NjMn+lLVYS3/XeoWk7WUVStmwKCeGGDXBn50Eb6ZlkwpGuNfhzDE4ZJPzvWYtTtK0KhLqG+orLB 1S7aaHa/OBY+X+7x0m9b9ujZeQoIeN/ljXLdcIcrHi0usr/q/IwJwdtCbhUsHD1MpDoXR/w== X-Received: by 2002:a05:6820:1621:b0:6a1:805b:5288 with SMTP id 006d021491bc7-6a53688627amr895125eaf.33.1784289186437; Fri, 17 Jul 2026 04:53:06 -0700 (PDT) Received: from localhost ([74.80.182.90]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6a516bb70c0sm1151776eaf.3.2026.07.17.04.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 04:53:04 -0700 (PDT) Date: Fri, 17 Jul 2026 14:52:58 +0300 From: Dan Carpenter To: "Luke Wang (OSS)" Cc: "adrian.hunter@intel.com" , "ulfh@kernel.org" , Bough Chen , Frank Li , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "imx@lists.linux.dev" , "linux-mmc@vger.kernel.org" , dl-S32 , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "harshit.m.mogalapalli@oracle.com" Subject: Re: [PATCH v7 8/8] mmc: sdhci-esdhc-imx: fix resume error handling Message-ID: References: <20260715071818.272318-1-ziniu.wang_1@oss.nxp.com> <20260715071818.272318-9-ziniu.wang_1@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Oh, heh. I missed the entire point of the patch... It should have just been: ret = pm_runtime_force_resume(dev); + if (ret) + return ret; Another way to silence the Sashiko warning about missing cleanup if mmc_gpio_set_cd_wake() failed would be to add a comment. ret = mmc_gpio_set_cd_wake(host->mmc, false); if (ret) { /* Just leak. It's fine. This path is impossible in 2026. */ return ret; } The other change was unrelated. regards, dan carpenter