From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 06/12] misc: Use named initializers for arrays of spi_device_data
Date: Fri, 17 Jul 2026 17:21:11 +0200 [thread overview]
Message-ID: <alpHil3vccGy11hn@monoceros> (raw)
In-Reply-To: <ad1f0b3efcc3d9d362b33753734cfb064c079cd3.1784299069.git.u.kleine-koenig@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
Hello,
On Fri, Jul 17, 2026 at 04:50:52PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> spi_device_id that replaces .driver_data by an anonymous union.
>
> While touching all these arrays, unify usage of whitespace.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
>
> Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
I fatfingered From: and S-o-b:, this should be
From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
and
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
respectively.
🤦, I even anticipated that error, but used `git grep @kernel.org
*.patch` instead of plain `grep ...` and as the patches are not under
version control, git showed no matches and I wrongly thought to have
gotten this right.
If this version of the series is to be applied, I appreciate an
according fixup.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-07-17 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 14:50 [PATCH v2 00/12] misc: Improvements around *_device_id defintions Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 01/12] misc: Drop unused assignment of spi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 02/12] misc/pvpanic: Drop unused assignment of acpi_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 03/12] misc: genwqe: Drop unused assignment of pci_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 04/12] misc: eeprom: Use named initializers for arrays of i2c_device_data Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 05/12] misc: " Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 06/12] misc: Use named initializers for arrays of spi_device_data Uwe Kleine-König (The Capable Hub)
2026-07-17 15:21 ` Uwe Kleine-König (The Capable Hub) [this message]
2026-07-17 14:50 ` [PATCH v2 07/12] misc: mei: Use named initializers for acpi_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 08/12] misc: mei: Use named initializer for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 09/12] misc: ibmvmc: Use named initializers for vio_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 10/12] misc: eeprom: idt_89hpesx: Unify style of of_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 11/12] misc: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-17 14:50 ` [PATCH v2 12/12] misc: Unify code style for various *_device_id arrays Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpHil3vccGy11hn@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox