From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61F8B3C4B68 for ; Fri, 17 Jul 2026 16:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784306383; cv=none; b=Z4nw3EsDFLUpbDHaAKROw9JEXvk4mSY3Jh5tJhGsaP3v2xx480l2dQJy7eS06JL1EGHE/mzR201813E0+LeHfD6OpFeYlxuH8/U3PK1yLNxmOiKRoHtPMc4qKWNLncBCrb/R1f3IeY3SltoYFRBs8QFd0f/f9pU+dviuHbhLt7U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784306383; c=relaxed/simple; bh=FdQXh4+5CHfeN/2GWV5SrUXe5uiiV0zi79cgKXrE+Zc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QNLsaEErQLJ1RxYdTlMcoJQIwMNvvhLeWUf6fsK9DX98wzKW/wj8YPKeXiYxigUzYJp8KAokm+k9QRQRfbeEyX3dU3x5MoCG6g3FkFtFHzd6oZ87g+ExilFq8ZXMvDdRkv0M2PuKCpxCqt/96im8eS0j+a+rxXcZ7RBeOr9IExg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Oy4ZaEHP; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Oy4ZaEHP" Date: Fri, 17 Jul 2026 09:39:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784306380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ya+InH9zHTxRKy9yFZiyuHezRl2aF6oKNFYbwfd+f4s=; b=Oy4ZaEHPqZyanD21ryxsXbU1/13Hkpzada47xZFUyF5M++wS7YQHG20dAXxvgg+59vgijG s75SnEW/PCi9s2/YZmD7DnbaGDHIU5/B+3ZPGohP0ERT4QHsmZ+tWtAQ6gfqI1IcClF6T9 JhBdBQVDKgCLWipu0EhrsYjQq8g4Jfo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Ridong Cc: Andrew Morton , Johannes Weiner , Kairui Song , Qi Zheng , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , David Hildenbrand , Michal Hocko , Lorenzo Stoakes , Zhongkun He , Muchun Song , Davidlohr Bueso , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ridong Chen Subject: Re: [PATCH 3/3] mm: vmscan: drop unused gfp_mask parameter from __node_reclaim() Message-ID: References: <20260717113300.214717-1-ridong.chen@linux.dev> <20260717113300.214717-4-ridong.chen@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260717113300.214717-4-ridong.chen@linux.dev> X-Migadu-Flow: FLOW_OUT On Fri, Jul 17, 2026 at 07:33:00PM +0800, Ridong wrote: > From: Ridong Chen > > Commit 57972c78e678 ("mm/vmscan: make __node_reclaim() more generic") > moved the scan_control construction out to the callers and passed the > struct in by pointer. After that change every use of the gfp mask inside > __node_reclaim() goes through sc->gfp_mask, leaving the gfp_mask parameter > unused. Just remove the dead parameter and update the callers accordingly. > No functional change. > > Signed-off-by: Ridong Chen Acked-by: Shakeel Butt