From: "Erik Inge Bolsø" <knan-lkml@anduin.net>
To: gregkh@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Staging: s626: only claim some subsystem ids
Date: Wed, 17 Jun 2009 02:25:48 +0200 (CEST) [thread overview]
Message-ID: <alpine.BSF.1.00.0906170212180.19435@anduin.net> (raw)
Fix comedi s626 driver mistakenly binding to SAA7146 dvb cards, match only
the same subsystem ids the vendor reference driver s626 v1.0.1 does.
Signed-off-by: Erik Inge Bolsø <knan-lkml@anduin.net>
---
drivers/staging/comedi/drivers/s626.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
Looks obvious enough, but totally untested patch. Vendor driver consulted
found from http://www.sensoray.com/products/626data.htm ... this driver
looks to have been forked from it years ago, according to the source
comments.
diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 30dec9d..5f1d373 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -111,7 +111,9 @@ static const struct s626_board s626_boards[] = {
#define PCI_DEVICE_ID_S626 0x7146
static DEFINE_PCI_DEVICE_TABLE(s626_pci_table) = {
- {PCI_VENDOR_ID_S626, PCI_DEVICE_ID_S626, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+ {PCI_VENDOR_ID_S626, PCI_DEVICE_ID_S626, 0x6000, 0x0626, 0, 0,
+ 0},
+ {PCI_VENDOR_ID_S626, PCI_DEVICE_ID_S626, 0x6000, 0x0272, 0, 0,
0},
{0}
};
--
1.5.6.3
reply other threads:[~2009-06-17 1:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.BSF.1.00.0906170212180.19435@anduin.net \
--to=knan-lkml@anduin.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®