mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "John Anthony Kazos Jr." <jakj@j-a-k-j.com>
To: aeb@cwi.nl
Cc: linux-kernel@vger.kernel.org
Subject: [RFC] partitions: CONFIG_BLK_DEV_MD and modular RAID support
Date: Sat, 7 Apr 2007 18:47:20 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.0.83.0704071836060.19488@sigma.j-a-k-j.com> (raw)

(Linux v2.6.20.6.)

The function md_autodetect_dev is defined in drivers/md/md.c. Its 
declaration is on line 1443, outside of conditionals. However, both its 
use on line 1455 and its definition on line 5600 are inside "#ifndef 
MODULE" conditionals. So it seems obvious that the declaration should be 
inside conditionals as well.

However, this function is separately declared and used in 
fs/partitions/check.c but not inside the same conditional, which means if 
md.c is compiled as a module, check.c will be referencing an undefined 
symbol.

Should the conditionals around md_autodetect_dev be changed to make sure 
CONFIG_BLK_DEV_MD=y, or does the function need to be extracted from md.c 
so it can be used by check.c in any case?

             reply	other threads:[~2007-04-07 22:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-07 22:47 John Anthony Kazos Jr. [this message]
2007-04-08  1:39 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.0.83.0704071836060.19488@sigma.j-a-k-j.com \
    --to=jakj@j-a-k-j.com \
    --cc=aeb@cwi.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®