mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Kujau <lists@nerdbynature.de>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Remove bashisms from scripts/extract-ikconfig
Date: Sat, 9 Jun 2007 21:22:00 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.0.99.0706092117580.8312@foobar-g4> (raw)

Hi,

I noticed that scripts/extract-ikconfig is using /bin/sh in its shebang 
but when /bin/sh is not a symlink to bash, it breaks with:

# scripts/extract-ikconfig /boot/vmlinux
scripts/extract-ikconfig: 11: function: not found
scripts/extract-ikconfig: 12: typeset: not found

The diff below seems to fix this.

Signed-off-by: Christian Kujau <lists@nerdbynature.de>

--- linux-2.6-dev/scripts/extract-ikconfig.orig	2007-06-01 22:53:49.000000000 +0200
+++ linux-2.6-dev/scripts/extract-ikconfig	2007-06-01 23:00:54.000000000 +0200
@@ -8,8 +8,8 @@ test -e $binoffset || cc -o $binoffset .

  IKCFG_ST="0x49 0x4b 0x43 0x46 0x47 0x5f 0x53 0x54"
  IKCFG_ED="0x49 0x4b 0x43 0x46 0x47 0x5f 0x45 0x44"
-function dump_config {
-    typeset file="$1"
+dump_config() {
+    file="$1"

      start=`$binoffset $file $IKCFG_ST 2>/dev/null`
      [ "$?" != "0" ] && start="-1"
@@ -18,8 +18,8 @@ function dump_config {
      fi
      end=`$binoffset $file $IKCFG_ED 2>/dev/null`

-    let start="$start + 8"
-    let size="$end - $start"
+    start="`expr $start + 8`"
+    size="`expr $end - $start`"

      dd if="$file" ibs=1 skip="$start" count="$size" 2>/dev/null | zcat


-- 
make bzImage, not war

             reply	other threads:[~2007-06-09 19:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-09 19:22 Christian Kujau [this message]
2007-06-09 19:26 ` Julio M. Merino Vidal
2007-06-09 19:34   ` Christian Kujau
2007-06-09 19:39     ` Julio M. Merino Vidal
2007-06-09 19:53     ` Willy Tarreau
2007-06-09 20:14       ` Christian Kujau
2007-11-14 23:44         ` Randy Dunlap
2008-11-12 18:39 [PATCH] remove " Werner Almesberger
2008-11-12 19:13 ` Randy Dunlap
2008-11-22 11:24 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.0.99.0706092117580.8312@foobar-g4 \
    --to=lists@nerdbynature.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®