From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765687AbXJZVJU (ORCPT ); Fri, 26 Oct 2007 17:09:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758824AbXJZVJG (ORCPT ); Fri, 26 Oct 2007 17:09:06 -0400 Received: from smtp-out.google.com ([216.239.33.17]:59396 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753917AbXJZVJF (ORCPT ); Fri, 26 Oct 2007 17:09:05 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=received:date:from:x-x-sender:to:cc:subject:in-reply-to: message-id:references:mime-version:content-type; b=Um3fPZDh0gcAJ/KWNXT5oTN1X4ArU7/B5XEJ7yfIesm+Zas935wZRVjuhP5f0nAiD gnbTJQ1gHAC7yt12QObwQ== Date: Fri, 26 Oct 2007 14:08:50 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Christoph Lameter cc: Paul Jackson , Lee.Schermerhorn@hp.com, akpm@linux-foundation.org, ak@suse.de, linux-kernel@vger.kernel.org Subject: Re: [patch 2/2] cpusets: add interleave_over_allowed option In-Reply-To: Message-ID: References: <20071025185506.8c373aa8.pj@sgi.com> <1193412644.5032.13.camel@localhost> <20071026120037.7b95a136.pj@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Oct 2007, Christoph Lameter wrote: > > Well, passing a single node to set_mempolicy() for MPOL_INTERLEAVE doesn't > > make a whole lot of sense in the first place. I prefer your solution of > > allowing set_mempolicy(MPOL_INTERLEAVE, NODE_MASK_ALL) to mean "interleave > > me over everything I'm allowed to access." NODE_MASK_ALL would be stored > > in the struct mempolicy and used later on mpol_rebind_policy(). > > So instead of an empty nodemask we would pass a nodemask where all bits > are set? And they would stay set but the cpuset restrictions would > effectively limit the interleaving to the allowed set? > You would pass NODE_MASK_ALL if your intent was to interleave over everything you have access to, yes. Otherwise you can pass whatever you want access to and your interleaved nodemask becomes mpol_rebind_policy()'s newmask formal (the cpuset's new mems_allowed) AND'd with pol->passed_nodemask.