From: David Rientjes <rientjes@google.com>
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Jackson <pj@sgi.com>, Christoph Lameter <clameter@sgi.com>,
Andi Kleen <ak@suse.de>, Mel Gorman <mel@csn.ul.ie>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/4] mempolicy: support optional mode flags
Date: Mon, 11 Feb 2008 11:34:03 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.1.00.0802111127080.1671@chino.kir.corp.google.com> (raw)
In-Reply-To: <1202747811.5014.37.camel@localhost>
On Mon, 11 Feb 2008, Lee Schermerhorn wrote:
> These patches look good--well, interesting, anyway. I'm "off on
> assignment" this week, so I won't get to review in detail, merge and
> test them until next...
>
If, by "interesting", you mean that they give the most power to the user
in setting up their mempolicies than they have ever had before, then I
agree.
> This helper functions introduced by this patch are similar in nature
> [but go further] to one I introduced in the reference counting cleanup
> RFC [http://marc.info/?l=linux-mm&m=119697614520515&w=4] I posted a
> while back. I've been holding these cleanup patches until Andrew starts
> accepting this sort of thing again. I have my series based atop Mel
> Gorman's [added to cc] "two zonelist" series, as it depends on removing
> the custom zonelist from the mempolicy.
>
If my helper functions are similar to yours then basing either of our
patchsets on top of the other should not be difficult.
> We need to sort out with Andrew, Mel, Paul, ... the order in which these
> interdependent changes go in. Given such an order, I'm willing to merge
> them all up, test them, and post them [after running checkpatch, of
> course].
>
Thanks for volunteering to test the changes. I don't know how many
patchsets are currently outstanding that touch mempolicies. So far we
have mine and the refcounting cleanup of yours that you mentioned.
I think the best way of dealing with it would be for the author of
whatever patchset is merged second to rebase off the current -mm just like
I based this entire patchset on your V3 contextualize_policy() patch from
a couple days ago.
> One other thing: In the recent mempolicy patch to "silently restrict
> nodemask], I mentioned the issue with regards to whether and when to
> "contextualize" tmpfs/hugetlbfs policies--if/when we fold
> mpol_check_policy() into mpol_new(), as you suggested. Once we can
> agree on the desired semantics, I had been thinking that an additional
> mode flag could be added to policies obtained from the superblock, and
> passed via mpol_shared_policy_init() [which calls mpol_new()] could be
> used for this purpose. Your change here seems to lay the foundation for
> implementing that.
>
My patchset already supports contextualized tmpfs mempolicies with a
template for how to specify them (see patch 4 in this series for the
documentation update). For example, mpol=interleave:1-3 is the equivalent
of MPOL_INTERLEAVE over nodes 1-3 while mpol=interleave=static:1-3 is the
equivalent of MPOL_INTERLEAVE | MPOL_F_STATIC_NODES.
David
next prev parent reply other threads:[~2008-02-11 19:36 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 15:30 [patch 1/4] mempolicy: convert MPOL constants to enum David Rientjes
2008-02-11 15:30 ` [patch 2/4] mempolicy: support optional mode flags David Rientjes
2008-02-11 15:30 ` [patch 3/4] mempolicy: add MPOL_F_STATIC_NODES flag David Rientjes
2008-02-11 15:30 ` [patch 4/4] mempolicy: update NUMA memory policy documentation David Rientjes
2008-02-11 16:10 ` Randy Dunlap
2008-02-11 20:06 ` [patch 4/4 v2] " David Rientjes
2008-02-11 20:14 ` Randy Dunlap
2008-02-11 18:25 ` [patch 3/4] mempolicy: add MPOL_F_STATIC_NODES flag KOSAKI Motohiro
2008-02-11 19:56 ` David Rientjes
2008-02-13 0:25 ` Lee Schermerhorn
2008-02-13 0:57 ` David Rientjes
2008-02-11 19:34 ` Christoph Lameter
2008-02-13 0:22 ` Lee Schermerhorn
2008-02-13 3:52 ` Paul Jackson
2008-02-13 4:03 ` David Rientjes
2008-02-13 4:13 ` Paul Jackson
2008-02-13 4:23 ` David Rientjes
2008-02-13 8:03 ` Paul Jackson
2008-02-13 9:36 ` David Rientjes
2008-02-13 16:01 ` Lee Schermerhorn
2008-02-13 18:48 ` David Rientjes
2008-02-13 18:58 ` Paul Jackson
2008-02-13 19:05 ` Lee Schermerhorn
2008-02-13 19:17 ` David Rientjes
2008-02-13 17:04 ` Paul Jackson
2008-02-13 19:02 ` David Rientjes
2008-02-13 20:29 ` Paul Jackson
2008-02-13 21:35 ` David Rientjes
2008-02-14 11:12 ` Paul Jackson
2008-02-14 12:27 ` Paul Jackson
2008-02-14 10:26 ` Paul Jackson
2008-02-14 19:45 ` David Rientjes
2008-02-15 10:19 ` Paul Jackson
2008-02-15 20:14 ` David Rientjes
2008-02-13 4:18 ` David Rientjes
2008-02-13 5:06 ` David Rientjes
2008-02-13 15:15 ` Lee Schermerhorn
2008-02-13 16:14 ` Lee Schermerhorn
2008-02-13 19:12 ` David Rientjes
2008-02-14 10:09 ` Paul Jackson
2008-02-14 19:40 ` David Rientjes
2008-02-15 1:44 ` David Rientjes
2008-02-15 10:00 ` Paul Jackson
2008-02-14 21:38 ` David Rientjes
2008-02-15 9:27 ` Paul Jackson
2008-02-15 20:23 ` David Rientjes
2008-02-15 20:32 ` David Rientjes
2008-02-15 23:45 ` Paul Jackson
2008-02-15 23:55 ` David Rientjes
2008-02-16 0:11 ` Paul Jackson
2008-02-11 16:36 ` [patch 2/4] mempolicy: support optional mode flags Lee Schermerhorn
2008-02-11 19:34 ` David Rientjes [this message]
2008-02-12 15:31 ` Lee Schermerhorn
2008-02-12 19:14 ` David Rientjes
2008-02-11 20:55 ` Paul Jackson
2008-02-11 21:52 ` David Rientjes
2008-02-11 21:57 ` Paul Jackson
2008-02-13 0:14 ` Lee Schermerhorn
2008-02-13 0:25 ` David Rientjes
2008-02-11 18:45 ` [patch 1/4] mempolicy: convert MPOL constants to enum Andi Kleen
2008-02-11 19:25 ` David Rientjes
2008-02-11 19:32 ` Christoph Lameter
2008-02-11 19:40 ` David Rientjes
2008-02-11 19:48 ` Christoph Lameter
2008-02-11 20:02 ` David Rientjes
2008-02-11 20:45 ` Christoph Lameter
2008-02-13 0:10 ` Lee Schermerhorn
2008-02-13 0:31 ` Paul Jackson
2008-02-13 0:53 ` David Rientjes
2008-02-13 1:04 ` Christoph Lameter
2008-02-13 1:28 ` Paul Jackson
2008-02-13 1:32 ` Paul Jackson
2008-02-13 2:00 ` David Rientjes
2008-02-13 2:22 ` Paul Jackson
2008-02-13 2:42 ` David Rientjes
2008-02-13 2:59 ` Paul Jackson
2008-02-13 3:17 ` David Rientjes
2008-02-13 3:22 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0802111127080.1671@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®