From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762960AbYCGJCn (ORCPT ); Fri, 7 Mar 2008 04:02:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762146AbYCGJCG (ORCPT ); Fri, 7 Mar 2008 04:02:06 -0500 Received: from smtp-out.google.com ([216.239.33.17]:3945 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762106AbYCGJCD (ORCPT ); Fri, 7 Mar 2008 04:02:03 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=received:date:from:x-x-sender:to:cc:subject:in-reply-to: message-id:references:user-agent:mime-version:content-type; b=q+2cPCFIlUHAsqdYAWvnqgLVu/NpLMYe6TSvMTJVOIo1VDJx86X82Hw8baeFTayim 7AbB0C/WReCPDhhmmJNJQ== Date: Fri, 7 Mar 2008 00:56:33 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Paul Menage cc: Balbir Singh , Andrew Morton , Pavel Emelianov , Hugh Dickins , Sudhir Kumar , YAMAMOTO Takashi , lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, taka@valinux.co.jp, linux-mm@kvack.org, KAMEZAWA Hiroyuki Subject: Re: [PATCH] Add cgroup support for enabling controllers at boot time In-Reply-To: <6599ad830803070040i5e54f5f3u9b4c753ac5a87771@mail.gmail.com> Message-ID: References: <20080306185952.23290.49571.sendpatchset@localhost.localdomain> <47D0C76D.8050207@linux.vnet.ibm.com> <6599ad830803070040i5e54f5f3u9b4c753ac5a87771@mail.gmail.com> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 Mar 2008, Paul Menage wrote: > > Since the command line is logically delimited by spaces, you can > > accidently disable a subsystem if its name appears in any of your kernel > > options following your cgroup_disable= option. > > I think that you're confusing this with things like the very early > memory init setup parameters, which do operate on the raw commandline. > > By the time anything is passed to a __setup() function, it's already > been split into separate strings at space boundaries. > Ok, so the cgroup_disable= parameter should be a list of subsystem names delimited by anything other than a space that the user wants disabled. That makes more sense, thanks.