mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steve VanDeBogart <vandebo-lkml@NerdBox.Net>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Roland McGrath <roland@redhat.com>,
	Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [PATCH] exit signals: use of uninitialized field notify_count
Date: Wed, 27 Aug 2008 17:27:00 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.1.00.0808271721140.15543@abydos.NerdBox.Net> (raw)
In-Reply-To: <20080827080136.GA4453@elte.hu>

On Wed, 27 Aug 2008, Ingo Molnar wrote:

>
> * Steve VanDeBogart <vandebo-lkml@NerdBox.Net> wrote:
>
>> task->signal->notify_count is only initialized if
>> task->signal->group_exit_task is not NULL.  Reorder a conditional so
>> that uninitialised memory is not used.  Found by Valgrind.
>>
>> Signed-off-by: Steve VanDeBogart <vandebo-lkml@nerdbox.net>
>
> Applied the commit below to tip/core/urgent, thanks. Roland/Oleg, do you
> concur with the fix?
>
> nice find btw. - are you running Valgrind on UML?

Thanks.  Yes, I am running Valgrind on UML.  I revisited the previous 
patches that allowed it and tried to remove any unnecessary changes.
The patches and a recipe on how to make it work can be found on the
UML wiki: http://uml.jfdi.org/uml/Wiki.jsp?page=ValgrindingUML

I'll stir up trouble by posting the kernel patches on lkml after a
little more cleanup.

--
Steve

      parent reply	other threads:[~2008-08-28  0:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 22:14 Steve VanDeBogart
2008-08-27  8:01 ` Ingo Molnar
2008-08-27 16:11   ` Oleg Nesterov
2008-08-28  0:58     ` Steve VanDeBogart
2008-08-28 12:58       ` Oleg Nesterov
2008-08-28  0:27   ` Steve VanDeBogart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.00.0808271721140.15543@abydos.NerdBox.Net \
    --to=vandebo-lkml@nerdbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®