From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753642AbZIITea (ORCPT ); Wed, 9 Sep 2009 15:34:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753134AbZIITea (ORCPT ); Wed, 9 Sep 2009 15:34:30 -0400 Received: from smtp-out.google.com ([216.239.33.17]:26487 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752770AbZIITe3 (ORCPT ); Wed, 9 Sep 2009 15:34:29 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=wSQwXKnXOZ/7wkQA/Y9fjo/D0fDv2MnJVluvndF5QJbyKHu59kxjq+CXhY8Vh5xm6 63/zvsd30UX5HquimZfug== Date: Wed, 9 Sep 2009 12:34:27 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Dave Hansen cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [patch 3/4 -mm] flex_array: poison free elements In-Reply-To: <1252524157.14385.37942.camel@nimitz> Message-ID: References: <1251129384.22398.7166.camel@nimitz> <1251150156.22398.8289.camel@nimitz> <1252510129.14385.37045.camel@nimitz> <1252524157.14385.37942.camel@nimitz> User-Agent: Alpine 1.00 (DEB 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Sep 2009, Dave Hansen wrote: > It shouldn't be too hard to do that, though. Although a bit silly to > have make a copy_to_user() call for each ->parts[] page, it would be > pretty easy to implement. > Right, but the event buffer becomes slower as a whole because of the multiple copy_to_user() on read, indirection into each flex_array_part, and add_event_entry() would now require a memcpy.