From: Steven Rostedt <rostedt@goodmis.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ftrace: dump out ftrace buffers to console on panic
Date: Wed, 30 Jul 2008 21:05:30 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0807302103340.20120@gandalf.stny.rr.com> (raw)
In-Reply-To: <20080730175640.f04f81b5.akpm@linux-foundation.org>
On Wed, 30 Jul 2008, Andrew Morton wrote:
>>
>> I don't mind making it unconditionally available. I only added the config
>> option because I thought people would like to turn it off.
>>
>> I'll resubmit with the above concerns fixed and without the config option.
>
> Well.. my question about the config option was no more than a question
> - I don't know the answer.
>
> Although thinking about it, I guess that anyone who is really squeezy
> on space just won't be enabling ftrace at all. Is there any reason
> other than size for disabling this new feature?
Just the output to the console on oops. But then again, it only prints a
lot if ftrace has stuff in the buffers.
I also lowered the count to keep the pain down when this was configured,
but since the size of the buffers is both boot time and run time
configurable, it shouldn't be a problem. If people want more buffer space,
they simply need to increase it at run time.
-- Steve
prev parent reply other threads:[~2008-07-31 1:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 21:13 Steven Rostedt
2008-07-30 21:30 ` Andrew Morton
2008-07-31 0:39 ` Steven Rostedt
2008-07-31 0:56 ` Andrew Morton
2008-07-31 1:05 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0807302103340.20120@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®