mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@saeurebad.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftrace: printk formatting infrastructure fix 2
Date: Mon, 11 Aug 2008 21:17:16 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.1.10.0808112112480.32393@gandalf.stny.rr.com> (raw)
In-Reply-To: <20080811162804.c437a761.akpm@linux-foundation.org>



On Mon, 11 Aug 2008, Andrew Morton wrote:

> On Fri, 08 Aug 2008 12:47:52 +0200
> Johannes Weiner <hannes@saeurebad.de> wrote:

> My attempts to generate a suitable config were not happy ones.  Feast
> your eyes upon this monstrosity:
> 
> Symbol: TRACING [=y]
> Selects: DEBUG_FS && STACKTRACE
> Selected by: FTRACE && HAVE_FTRACE || IRQSOFF_TRACER && TRACE_IRQFLAGS_SUPPORT && GENERIC_TIME && HAVE_FTRACE || PREEMPT_TRACER && GENERIC_TIME && PREEMPT && HAVE_FTRACE || SYSPROF_TRACER && X86 || SCHED_TRACER && HAVE_FTRACE || CONTEXT_SWITCH_TRACER && HAVE_FTRACE || MMIOTRACE && DEBUG_KERNEL && PCI
> 

This isn't as bad as it looks.

Yes tracing selects DEBUG_FS and STACKTRACE, but the TRACING is required 
to transcend into the kernel/trace directory. That is where the other 
tracers live, and some tracers require other options to be set.

ie. FTRACE requires HAVE_FTRACE, PREEMPT_TRACER requires PREEMPT, etc.

I don't really see a problem with those config dependencies.

-- Steve




  parent reply	other threads:[~2008-08-12  1:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200808062133.m76LXpGk016460@imap1.linux-foundation.org>
2008-08-07 13:40 ` Johannes Weiner
2008-08-08 10:47   ` Johannes Weiner
     [not found]     ` <20080811162804.c437a761.akpm@linux-foundation.org>
2008-08-12  1:17       ` Steven Rostedt [this message]
2008-08-07 13:42 ` [PATCH] lockdep: spin_lock_nest_lock fix Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.0808112112480.32393@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@saeurebad.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®