From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1753283AbYIZRq4@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753283AbYIZRq4 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Sep 2008 13:46:56 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751890AbYIZRqs
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 26 Sep 2008 13:46:48 -0400
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:43383 "EHLO
	hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751475AbYIZRqr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Sep 2008 13:46:47 -0400
Date: Fri, 26 Sep 2008 13:46:45 -0400 (EDT)
From: Steven Rostedt <rostedt@goodmis.org>
X-X-Sender: rostedt@gandalf.stny.rr.com
To: Linus Torvalds <torvalds@linux-foundation.org>
cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
       Masami Hiramatsu <mhiramat@redhat.com>,
       LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
       Thomas Gleixner <tglx@linutronix.de>,
       Peter Zijlstra <peterz@infradead.org>,
       Andrew Morton <akpm@linux-foundation.org>, prasad@linux.vnet.ibm.com,
       Mathieu Desnoyers <compudj@krystal.dyndns.org>,
       "Frank Ch. Eigler" <fche@redhat.com>, David Wilder <dwilder@us.ibm.com>,
       hch@lst.de, Martin Bligh <mbligh@google.com>,
       Christoph Hellwig <hch@infradead.org>,
       Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH v5] Unified trace buffer
In-Reply-To: <alpine.LFD.1.10.0809261036420.3265@nehalem.linux-foundation.org>
Message-ID: <alpine.DEB.1.10.0809261346040.21618@gandalf.stny.rr.com>
References: <20080925185154.230259579@goodmis.org> <20080925185236.244343232@goodmis.org> <alpine.DEB.1.10.0809252101080.8124@gandalf.stny.rr.com> <48DC406D.1050508@redhat.com> <alpine.DEB.1.10.0809261245420.21618@gandalf.stny.rr.com>
 <20080926173130.GE15446@ghostprotocols.net> <alpine.LFD.1.10.0809261036420.3265@nehalem.linux-foundation.org>
User-Agent: Alpine 1.10 (DEB 962 2008-03-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Fri, 26 Sep 2008, Linus Torvalds wrote:

> 
> 
> On Fri, 26 Sep 2008, Arnaldo Carvalho de Melo wrote:
> > 
> > Why do you need __packed__ here? With or without it the layout is the

>>From just being paranoid.

> > same:
> 
> Indeed. And on some architectures 'packed' will actually mean that the 
> compiler may think that it's unaligned, and then generate much worse code 
> to access the fields. So if you align things anyway (and you do), then 
> 'packed' is the wrong thing to do.

OK, I'm making v6 now with various cleanups. I'll nuke it on that one.

-- Steve