mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
	Martin Bligh <mbligh@google.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org, prasad@linux.vnet.ibm.com,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	od@suse.com, Andrew Morton <akpm@linux-foundation.org>,
	hch@lst.de, David Wilder <dwilder@us.ibm.com>,
	Tom Zanussi <zanussi@comcast.net>
Subject: Re: [RFC PATCH] LTTng relay buffer allocation, read, write
Date: Tue, 30 Sep 2008 16:21:14 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.1.10.0809301620080.7993@gandalf.stny.rr.com> (raw)
In-Reply-To: <20080930200112.GD27822@redhat.com>


On Tue, 30 Sep 2008, Frank Ch. Eigler wrote:
> On Tue, Sep 30, 2008 at 03:43:45PM -0400, Steven Rostedt wrote:
> > [...]
> > On Tue, 30 Sep 2008, Mathieu Desnoyers wrote:
> > > 
> > > You are actually using them to put redundant information that could be
> > > encoded differently and thus save 4 bits per event records, more or less
> > > what will be needed by most tracers (15 IDs, 1 reserved for an extended
> > > ID field).
> > 
> > I really like the idea of keeping the tracer event ids out of the ring 
> > buffer logic.
> 
> That's fine for a ring buffer that only ever contains data from one
> event source.  How do you imagine multiplexing working, where one
> wants to grep a single debugfs file that contains data from different
> event sources?  Punt to another layer?

Field goal!

Yes! That is exactly what I want. If your trace has only one event, why 
would it want to record them?  The event id belongs in the tracer layer 
not the ring buffer layer.

I would like to make a "trace_buffer" layer that includes all of this.

-- Steve


  reply	other threads:[~2008-09-30 20:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-27 13:40 Mathieu Desnoyers
2008-09-27 17:10 ` Peter Zijlstra
2008-09-28  8:59   ` Peter Zijlstra
2008-09-29 16:06     ` Mathieu Desnoyers
2008-09-29 15:50   ` Mathieu Desnoyers
2008-09-29 16:38     ` Steven Rostedt
2008-09-29 18:38       ` Mathieu Desnoyers
2008-09-29 19:40         ` Steven Rostedt
2008-09-29 19:54           ` Steven Rostedt
2008-09-29 17:30     ` Peter Zijlstra
2008-09-29 20:31       ` Mathieu Desnoyers
2008-09-29 21:24         ` Steven Rostedt
2008-09-30 17:22           ` Martin Bligh
2008-09-30 17:23             ` Martin Bligh
2008-09-30 18:14               ` Mathieu Desnoyers
2008-09-30 18:22                 ` Steven Rostedt
2008-09-30 18:35                   ` Mathieu Desnoyers
2008-09-30 19:43                     ` Steven Rostedt
2008-09-30 20:01                       ` Frank Ch. Eigler
2008-09-30 20:21                         ` Steven Rostedt [this message]
2008-09-30 19:44                     ` Martin Bligh
2008-09-30 19:54                       ` Mathieu Desnoyers
2008-09-30 20:49                         ` Martin Bligh
2008-09-30 20:55                           ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.0809301620080.7993@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dwilder@us.ibm.com \
    --cc=fche@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mbligh@google.com \
    --cc=od@suse.com \
    --cc=prasad@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=zanussi@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®