From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>
Subject: [PATCH] ftrace: move pc counter in irqstrace
Date: Thu, 2 Oct 2008 19:23:04 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0810021921500.26504@gandalf.stny.rr.com> (raw)
The assigning of the pc counter is in the wrong spot in the
check_critical_timing function. The pc variable is used in the
out jump.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace_irqsoff.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-tip.git/kernel/trace/trace_irqsoff.c
===================================================================
--- linux-tip.git.orig/kernel/trace/trace_irqsoff.c 2008-10-02 09:07:16.000000000 -0400
+++ linux-tip.git/kernel/trace/trace_irqsoff.c 2008-10-02 14:16:54.000000000 -0400
@@ -142,11 +142,11 @@ check_critical_timing(struct trace_array
local_save_flags(flags);
+ pc = preempt_count();
+
if (!report_latency(delta))
goto out;
- pc = preempt_count();
-
spin_lock_irqsave(&max_trace_lock, flags);
/* check if we are still the max latency */
next reply other threads:[~2008-10-02 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-02 23:23 Steven Rostedt [this message]
2008-10-03 7:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0810021921500.26504@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®