From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754479AbYKMN7g (ORCPT ); Thu, 13 Nov 2008 08:59:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752755AbYKMN72 (ORCPT ); Thu, 13 Nov 2008 08:59:28 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:44890 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbYKMN71 (ORCPT ); Thu, 13 Nov 2008 08:59:27 -0500 Date: Thu, 13 Nov 2008 08:59:25 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Ingo Molnar cc: linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner , Pekka Paalanen , Frederic Weisbecker , Steven Rostedt Subject: Re: [PATCH v2 1/1] ftrace: do not update max buffer with no users In-Reply-To: Message-ID: References: <20081113043449.751885305@goodmis.org> <20081113043751.796120007@goodmis.org> <20081113084040.GD25479@elte.hu> <20081113131939.GA2669@elte.hu> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Nov 2008, Steven Rostedt wrote: > Right now I'm thinking my other suggestion is the best. Just allocate the > max_tr.buffer and get rid of the CONFIG. This solution is very small, and > covers all corner cases. And for 29, we can change the code so that the max_tr buffer is only allocated by request of a tracer at plugin time. In which we can do tests if the max_tr.buffer exists in the use cases, and warn if it does not (a plugin needs to request a max_tr buffer before using update_max_tr). -- Steve