From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753749AbYKZCWP (ORCPT ); Tue, 25 Nov 2008 21:22:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752726AbYKZCV7 (ORCPT ); Tue, 25 Nov 2008 21:21:59 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:52186 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbYKZCV7 (ORCPT ); Tue, 25 Nov 2008 21:21:59 -0500 Date: Tue, 25 Nov 2008 21:21:58 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Ingo Molnar cc: Frederic Weisbecker , Linux Kernel Subject: Re: [PATCH] tracing/function-return-tracer: set a more human readable output In-Reply-To: <20081126021450.GA17617@elte.hu> Message-ID: References: <492C90E5.8070907@gmail.com> <20081126003936.GA26937@elte.hu> <20081126021450.GA17617@elte.hu> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Nov 2008, Ingo Molnar wrote: > > the regex filter doesnt work well yet when used with the graph tracer: > > [ 2994.079079] ------------[ cut here ]------------ > [ 2994.079079] WARNING: at kernel/trace/ftrace.c:373 ftrace_bug+0x8c/0x1ce() > [ 2994.079079] Modules linked in: > [ 2994.079079] Pid: 12, comm: kstop/0 Not tainted 2.6.28-rc6-tip #2056 > [ 2994.079079] Call Trace: > [ 2994.079079] [] warn_on_slowpath+0x46/0x60 > [ 2994.079079] [] ? trace_graph_return+0x89/0xa7 > [ 2994.079079] [] ? trace_graph_return+0x89/0xa7 > [ 2994.079079] [] ? ftrace_return_to_handler+0x6b/0x74 > [ 2994.079079] [] ? memcpy+0xe/0x31 > [ 2994.079079] [] ? rb_commit+0x29/0x2d > [ 2994.079079] [] ? ring_buffer_unlock_commit+0x15/0x1a > [ 2994.079079] [] ? ftrace_modify_code+0x21/0xa3 > [ 2994.079079] [] ? ftrace_return_to_handler+0x6b/0x74 > [ 2994.079079] [] ? probe_kernel_read+0xe/0x5c > [ 2994.079079] [] ? trace_selftest_dynamic_test_func+0x3/0xc > [ 2994.079079] [] ? return_to_handler+0xa/0x14 > [ 2994.079079] [] ? trace_selftest_dynamic_test_func+0x3/0xc > [ 2994.079079] [] ? ftrace_modify_code+0x38/0xa3 > [ 2994.079079] [] ? trace_selftest_dynamic_test_func+0x3/0xc > [ 2994.079079] [] ftrace_bug+0x8c/0x1ce > [ 2994.079079] [] ftrace_replace_code+0x111/0x13d > [ 2994.079079] [] ? stop_cpu+0x0/0xa5 > [ 2994.079079] [] __ftrace_modify_code+0x1e/0x32 > [ 2994.079079] [] stop_cpu+0x6b/0xa5 > [ 2994.079079] [] return_to_handler+0x0/0x14 > [ 2994.079079] [] return_to_handler+0x0/0x14 > [ 2994.079079] [] ? autoremove_wake_function+0x0/0x35 > [ 2994.079079] [] ? worker_thread+0x0/0xc7 > [ 2994.079079] [] kthread+0x40/0x66 > [ 2994.079079] [] ? kthread+0x0/0x66 > [ 2994.079079] [] kernel_thread_helper+0x7/0x10 > [ 2994.079079] ---[ end trace bff97d149b80ecde ]--- > [ 2994.079079] ftrace failed to modify [] trace_selftest_dynamic_test_func+0x3/0xc > [ 2994.079079] actual: e8:0c:1a:fa:ff > > produced via: > > # cd /debug/tracing/ > # cat set_ftrace_filter > # echo schedule > set_ftrace_filter > # cat set_ftrace_filter > cat: set_ftrace_filter: No such device This is probably fixed with my patch set. -- Steve