mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Liming Wang <liming.wang@windriver.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ftrace: adding other non-leaving .text sections
Date: Tue, 25 Nov 2008 22:03:35 -0500 (EST)	[thread overview]
Message-ID: <alpine.DEB.1.10.0811252201270.26424@gandalf.stny.rr.com> (raw)
In-Reply-To: <1227666566-9044-1-git-send-email-liming.wang@windriver.com>


On Wed, 26 Nov 2008, Liming Wang wrote:

> Please review this patch, and I don't know whether new sections will conflict 
> with sched tracer or others. 
> This patch is against Steven tree's tip/devel latest commit.
> 
> Impact: improve recordmcount.pl
> 
> Besides .text section, there are three .text sections that won't
> be freed after kernel booting. They are: .sched.text, .spinlock.text
> and .kprobes.text, which contain functions we can trace. But the last
> section ".kprobes.text" is particular, which has been marked as "notrace",
> we ignore it. Thus we add other two sections.

Yep, only those sections that we know will not disappear are OK. I was
conservative with only using ".text" but I knew there were other sections 
that were OK, so I used the hash array to make it easy to add others.

Thanks!

Acked-by: Steven Rostedt <srostedt@redhat.com>

-- Steve

> 
> Signed-off-by: Liming Wang <liming.wang@windriver.com>
> ---
>  scripts/recordmcount.pl |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> index 0197e2f..0b1dc9f 100755
> --- a/scripts/recordmcount.pl
> +++ b/scripts/recordmcount.pl
> @@ -112,6 +112,8 @@ my ($arch, $bits, $objdump, $objcopy, $cc,
>  # Acceptable sections to record.
>  my %text_sections = (
>       ".text" => 1,
> +     ".sched.text" => 1,
> +     ".spinlock.text" => 1,
>  );
>  
>  $objdump = "objdump" if ((length $objdump) == 0);
> -- 
> 1.6.0.3
> 
> 
> 

  parent reply	other threads:[~2008-11-26  3:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26  2:29 Liming Wang
2008-11-26  2:49 ` Ingo Molnar
2008-11-26  3:03 ` Steven Rostedt [this message]
2008-11-26  3:04   ` Paul Mundt
2008-11-26  3:14     ` walimis
2008-11-26  3:18       ` Paul Mundt
2008-11-26  3:24         ` walimis
2008-11-26  3:20     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.0811252201270.26424@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=liming.wang@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®