From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758742AbZAHEuB (ORCPT ); Wed, 7 Jan 2009 23:50:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752380AbZAHEtw (ORCPT ); Wed, 7 Jan 2009 23:49:52 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:41722 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbZAHEtw (ORCPT ); Wed, 7 Jan 2009 23:49:52 -0500 Date: Wed, 7 Jan 2009 23:49:49 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Frederic Weisbecker cc: Ingo Molnar , Linux Kernel Mailing List , Pekka Enberg Subject: Re: [PATCH 2/2] tracing/branch-tracer: adapt to the stat tracing API In-Reply-To: <4956b070.0c07560a.2b34.2325@mx.google.com> Message-ID: References: <4956b070.0c07560a.2b34.2325@mx.google.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Dec 2008, Frederic Weisbecker wrote: > This patch adapts the branch tracer to the tracing API. > This is not really for inclusion but more likely a proof of concept because > the branch tracer implements two "stat tracing" that were split in two files. > > So I added an option to the branch tracer: stat_all_branch. > If it is set, then trace_stat will output all of the branches entries stats. > Otherwise, it will print the annotated branches. > > Its is a kind of quick trick, waiting for a better solution. > By default, the annotated branches stat are sorted by incorrect branch prediction > percentage. > OK, I have not had a chance to look at this code since it was sent when I was on Holiday. But I do not think that the only way to see the output of a histogram is to set it in the current_tracer. If I have the branch tracer on, I would have to run it to see the output of the histogram. The histogram starts recording at boot up. Although the branch tracer is dependent on the histograms, the histogram is not dependent on the branch tracer. This code is making the histogram dependent on the trace. It took me a while to figure out how to see my histogram. With the new patches (after the compile issue is solved) we could have a register_histogram or something that would put the file in the trace_stats directory. This would separate the need of coupling the tracers with the histogram even when they are not coupled. -- Steve