From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756748AbZBIRmw (ORCPT ); Mon, 9 Feb 2009 12:42:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754921AbZBIRmo (ORCPT ); Mon, 9 Feb 2009 12:42:44 -0500 Received: from x35.xmailserver.org ([64.71.152.41]:46369 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbZBIRmn (ORCPT ); Mon, 9 Feb 2009 12:42:43 -0500 X-AuthUser: davidel@xmailserver.org Date: Mon, 9 Feb 2009 09:42:41 -0800 (PST) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: mtk.manpages@gmail.com cc: Linux Kernel Mailing List , Thomas Gleixner , Andrew Morton Subject: Re: [patch 2/2] timerfd extend clockid support In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (DEB 962 2008-03-14) X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Feb 2009, Michael Kerrisk wrote: > On Mon, Feb 9, 2009 at 12:23 PM, Davide Libenzi wrote: > > The following patch extends timerfd clockid support to cover the ones > > supported by timer_create(). > > It exports the invalid_clockid() function outside posix-timers.c to allow > > timerfd to properly check input parameters. > > Andrew, this is (eventually) .30 material, and do not take the patch > > until you have Thomas sign off. > > Thomas, timerfd uses core hrtimer functions for its tasks. By extending > > the clockid support, I assume that the clockids other than CLOCK_MONOTONIC > > and CLOCK_REALTIME, behaves the same from a hrtimer caller POV. Right? > > Hi Davide, > > Have you done any testing of this patch? My attempts at testing with > clocks other than REALTIME and MONOTONIC all don't work so far. In > some cases, my test programs causes the system to hang. Try > experimenting with the (not yet well tested) test program below, to > check the behavior with other clocks. Michael, no I did not test it and I did not have even the time to peek into the core timer code to see if the usage of other timer types in eventfd would create problems. That's why I asked Thomas if they'd behave differently from an hrtimer caller POV. I'll try to take a look by myself today or tomorrow. - Davide