From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760050AbZBXRdb (ORCPT ); Tue, 24 Feb 2009 12:33:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757265AbZBXRdU (ORCPT ); Tue, 24 Feb 2009 12:33:20 -0500 Received: from smtp3.ultrahosting.com ([74.213.175.254]:41735 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759421AbZBXRdT (ORCPT ); Tue, 24 Feb 2009 12:33:19 -0500 Date: Tue, 24 Feb 2009 12:24:28 -0500 (EST) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Mel Gorman cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra Subject: Re: [PATCH 06/19] Check only once if the zonelist is suitable for the allocation In-Reply-To: <1235477835-14500-7-git-send-email-mel@csn.ul.ie> Message-ID: References: <1235477835-14500-1-git-send-email-mel@csn.ul.ie> <1235477835-14500-7-git-send-email-mel@csn.ul.ie> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Feb 2009, Mel Gorman wrote: > It is possible with __GFP_THISNODE that no zones are suitable. This > patch makes sure the check is only made once. GFP_THISNODE is only a performance factor if SLAB is the slab allocator. The restart logic in __alloc_pages_internal() is mainly used by OOM processing. But the patch looks okay regardless... Reviewed-by: Christoph Lameter