From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756881AbZEDQGE (ORCPT ); Mon, 4 May 2009 12:06:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751567AbZEDQFv (ORCPT ); Mon, 4 May 2009 12:05:51 -0400 Received: from smtp.ultrahosting.com ([74.213.174.254]:36001 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755973AbZEDQFu (ORCPT ); Mon, 4 May 2009 12:05:50 -0400 Date: Mon, 4 May 2009 11:54:53 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@qirst.com To: Cyrill Gorcunov cc: Ingo Molnar , Andrew Morton , Mel Gorman , LKML , Pekka Enberg , Rik van Riel , David Rientjes , Pavel Emelyanov Subject: Re: [PATCH -tip] mm: introduce __GFP_PANIC modifier In-Reply-To: <20090504152026.GO4173@lenovo> Message-ID: References: <20090504122740.GH4173@lenovo> <20090504131311.GA23330@elte.hu> <20090504131638.GJ4173@lenovo> <20090504141256.GK4173@lenovo> <20090504142903.GM4173@lenovo> <20090504152026.GO4173@lenovo> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 May 2009, Cyrill Gorcunov wrote: > You know I only found a message in case if page is already > not granted (ie NULL is going to be returned) and right > before that we print a warning about that (nopage: label). > Which means - no panic here and with (__GFP_NOFAIL | __GFP_REPEAT) > just spinning around in attepmt to allocate new memory. And how > to behave on atomic allocations. Almost give up... :) Could you check for __GFP_FAIL|__GFP_REPEAT somewheres and panic? Not sure if __GFP_REPEAT is the right second flag to use.