mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux-foundation.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net
Subject: Re: [PATCH 2/2] SLUB: Disable debugging if it increases the minimum page order
Date: Thu, 11 Jun 2009 14:26:02 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.1.10.0906111422360.11973@gentwo.org> (raw)
In-Reply-To: <20090611180422.GJ7302@csn.ul.ie>

On Thu, 11 Jun 2009, Mel Gorman wrote:

> "With SLUB_DEBUG, enable debug on all caches unless the increased meta-data
> would force the minimum order up on order due to object sizes being near or
> equal the PAGE_SIZE. If SLUB_DEBUG must be enabled, specify slub_debug=A for
> 'All caches enable debug regardless'"

Hmmm... No SLUB_DEBUG just compiles the code in for debugging. Does not
enable anything.

But we could make SLUB_DEBUG_ON enable debugging except on those slabs
where the order increases (for which it does a printk saying that the
debugging was disabled) and then have a slub_debug=A option that
overrides the order check. Generally if you know that you have memory
corruption you would want to boot with slub_debug=A. If you just want
continuous checks then SLUB_DEBUG_ON would do the trick.


  reply	other threads:[~2009-06-11 19:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11  8:44 Pekka J Enberg
2009-06-11 13:43 ` Christoph Lameter
2009-06-11 14:00   ` Pekka Enberg
2009-06-11 14:24     ` Christoph Lameter
2009-06-11 15:11       ` Pekka Enberg
2009-06-11 15:20         ` Christoph Lameter
2009-06-11 15:28           ` Pekka Enberg
2009-06-11 15:49             ` Christoph Lameter
2009-06-11 16:49               ` Larry Finger
2009-06-11 18:04               ` Mel Gorman
2009-06-11 18:26                 ` Christoph Lameter [this message]
2009-06-11 19:16                   ` Mel Gorman
2009-06-11 14:39     ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.0906111422360.11973@gentwo.org \
    --to=cl@linux-foundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mel@csn.ul.ie \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®