From: Tim Abbott <tabbott@ksplice.com>
To: Hirokazu Takata <takata@linux-m32r.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section.
Date: Mon, 7 Sep 2009 10:35:59 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.1.10.0909071022080.17860@dr-wily.mit.edu> (raw)
In-Reply-To: <swfzl97hr8g.wl%takata.hirokazu@renesas.com>
On Mon, 7 Sep 2009, Hirokazu Takata wrote:
> From: Tim Abbott <tabbott@ksplice.com>
> Subject: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section.
> Date: Sun, 06 Sep 2009 23:12:58 -0400
> > Since these get squashed into the .data output section by the m32r
> > linker script, it seems likely that they don't need their own input
> > sections.
> >
> > I'd like an explicit confirmation from Hirokazu Takata that this is
> > correct (in particular, that there isn't some hidden reason why there
> > two structures need to be at the start of the .data output section).
>
> There is no apparent reason. We've placed them at the start of .data
> section, because they are for initial stack region.
>
> I think it would be better that we place them to .init.data section.
> Any comment?
Assuming that they aren't used after the initial boot process, that's
probably the right choice.
-Tim Abbott
next prev parent reply other threads:[~2009-09-07 14:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-07 3:12 [PATCH 1/6] m32r: make PAGE_SIZE available to assembly Tim Abbott
2009-09-07 3:12 ` [PATCH 2/6] m32r: Define THREAD_SIZE only once Tim Abbott
2009-09-07 5:52 ` Hirokazu Takata
2009-09-07 6:41 ` Hirokazu Takata
2009-09-07 3:12 ` [PATCH 3/6] m32r: Move GET_THREAD_INFO definition out of asm/thread_info.h Tim Abbott
2009-09-07 3:12 ` [PATCH 4/6] m32r: Remove unused .altinstructions and .exit.* code from linker script Tim Abbott
2009-09-07 3:12 ` [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section Tim Abbott
2009-09-07 12:30 ` Hirokazu Takata
2009-09-07 14:35 ` Tim Abbott [this message]
2009-09-07 3:12 ` [PATCH 6/6] m32r: Cleanup linker script using new linker script macros Tim Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.0909071022080.17860@dr-wily.mit.edu \
--to=tabbott@ksplice.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=takata@linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®